Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: chrome/browser/ui/overlay/overlay_window.h

Issue 2905833004: [OverlayWindow] Add platform-independent window and views implementation. (Closed)
Patch Set: Remove BaseWindow subclassing per conversation with sky@. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_UI_OVERLAY_OVERLAY_WINDOW_H_
6 #define CHROME_BROWSER_UI_OVERLAY_OVERLAY_WINDOW_H_
7
8 #include "ui/compositor/layer.h"
sky 2017/07/11 18:02:25 forward declare this (assuming you need Layer, whi
apacible 2017/07/18 01:08:27 Done. Included ui/gfx/native_widget_types.h becaus
9
10 // This window will always float above other windows. The intention is to show
11 // content perpetually while the user is still interacting with the other
12 // browser windows.
13 class OverlayWindow {
14 public:
15 OverlayWindow() {}
16 virtual ~OverlayWindow() {}
mlamouri (slow - plz ping) 2017/07/07 10:34:38 = default for both
apacible 2017/07/18 01:08:28 Done.
17
18 // Returns a created OverlayWindow. This is defined in the platform-specific
19 // implementation for the class.
20 static std::unique_ptr<OverlayWindow> Create();
21
22 virtual void Init() = 0;
23 virtual bool IsActive() const = 0;
24 virtual void Show() = 0;
25 virtual void Hide() = 0;
26 virtual void Close() = 0;
27 virtual void Activate() = 0;
28 virtual bool IsAlwaysOnTop() const = 0;
sky 2017/07/11 18:02:25 Is this really needed? Same question for GetLayer.
apacible 2017/07/18 01:08:28 Yes, we want these both to be exposed.
29 virtual ui::Layer* GetLayer() = 0;
30 virtual gfx::NativeWindow GetNativeWindow() const = 0;
31 virtual gfx::Rect GetBounds() const = 0;
32
33 private:
34 DISALLOW_COPY_AND_ASSIGN(OverlayWindow);
35 };
36
37 #endif // CHROME_BROWSER_UI_OVERLAY_OVERLAY_WINDOW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698