Make Image::image_observer_ WeakPersistent

third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp

Index: third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp
diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp b/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp
index de6e9ec4ff408fbbe1808d91da72d759099766d8..d285916f362da924660cc8509e2723f87efbb552 100644
--- a/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp
+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp
@@ -118,7 +118,8 @@ void SVGImageChromeClient::AnimationTimerFired(TimerBase*) {
   //
   // TODO(Oilpan): move (SVG)Image to the Oilpan heap, and avoid
   // this explicit lifetime check.

[haraken, 2017/05/25 23:23:02]

Is it still hard to move Image to Oilpan's heap?

[hiroshige, 2017/05/26 00:03:27]

I'm not sure. Were there any blocking issues to move Image to Oilpan heap?

(Related issue: Issue 719617 about thread affinity of Image)

-  if (ThreadHeap::WillObjectBeLazilySwept(image_->GetImageObserver()))
+  if (image_->GetImageObserver() &&
+      ThreadHeap::WillObjectBeLazilySwept(image_->GetImageObserver()))

[haraken, 2017/05/25 23:23:02]

Now that Image::image_observer_ is cleared in the stop-the-world phase, we can
remove the WillObjectBeLazilySwept check.

+Sigbjorn for double-checking.

[hiroshige, 2017/05/26 18:44:58]

Done.

     return;
 
   image_->ServiceAnimations(MonotonicallyIncreasingTime());