third_party/WebKit/LayoutTests/svg/as-image/adopt-while-async-svg-load-is-in-progress-crash.html - Issue 2905833003: Make Image::image_observer_ WeakPersistent

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/as-image/adopt-while-async-svg-load-is-in-progress-crash.html

Issue 2905833003: Make Image::image_observer_ WeakPersistent (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 var t = async_test("Garbage collection of ImageResourceContent while " +

	6 "asynchronous loading of SVG is in progress " +

	7 "shouldn't crash. crbug.com/726220");

	8 var img;

	9

	10 function step1() {

	11 setTimeout(t.step_func(step2), 0);

	12

	13 // 1. Creating an <img> element with SVG of which loading is not completed

	14 // synchronously.

	15 img = document.createElement('img');

	16 img.src='data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg"><foreignOb ject><body xmlns="http://www.w3.org/1999/xhtml"><marquee></marquee></body></fore ignObject></svg>';

	17 document.body.appendChild(img);

	18 assert_false(img.complete);

	19 }

	20

	21 function step2() {

	22 // 2. Adopt the <img> to a new document.

	23 newdoc = document.implementation.createDocument("svg", null);

	24 newdoc.adoptNode(img);

	25

	26 // 3. Do garbage collection. The oold ImageResourceContent is garbage

	27 // collected while async SVG loading is still in progress.

	28 gc();

	29

	30 setTimeout(t.step_func_done(function() {}), 100);
	fs 2017/05/26 08:28:36 Nit: Don't need an empty function here. (Can just Nit: Don't need an empty function here. (Can just do step_func_done().) hiroshige 2017/05/26 18:44:58 Done. Show quoted text On 2017/05/26 08:28:36, fs wrote: > Nit: Don't need an empty function here. (Can just do step_func_done().) Done.
	31 }

	32

	33 </script>

	34 <body onload="setTimeout(t.step_func(step1), 0)"></body>

OLD	NEW