Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc

Issue 2905823002: Add Mojo interfaces for GpuJpegDecodeAccelerator and GpuJpegDecodeAcceleratorHost (Closed)
Patch Set: updated comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc
diff --git a/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc b/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc
index c2f6090e1434432dc89b6a332ddaf46f4ee9bd0f..2d55e826138898527727e8a6286ff9178e0eaa31 100644
--- a/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc
+++ b/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc
@@ -380,7 +380,7 @@ GpuJpegDecodeAccelerator::GpuJpegDecodeAccelerator(
client_number_(0) {}
GpuJpegDecodeAccelerator::~GpuJpegDecodeAccelerator() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
if (filter_) {
channel_->RemoveFilter(filter_.get());
}
@@ -388,7 +388,7 @@ GpuJpegDecodeAccelerator::~GpuJpegDecodeAccelerator() {
void GpuJpegDecodeAccelerator::AddClient(int32_t route_id,
base::Callback<void(bool)> response) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
// When adding non-chromeos platforms, VideoCaptureGpuJpegDecoder::Initialize
// needs to be updated.
@@ -435,12 +435,12 @@ void GpuJpegDecodeAccelerator::NotifyDecodeStatus(
int32_t route_id,
int32_t buffer_id,
JpegDecodeAccelerator::Error error) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
Send(new AcceleratedJpegDecoderHostMsg_DecodeAck(route_id, buffer_id, error));
}
void GpuJpegDecodeAccelerator::ClientRemoved() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK_GT(client_number_, 0);
client_number_--;
if (client_number_ == 0) {
@@ -450,8 +450,25 @@ void GpuJpegDecodeAccelerator::ClientRemoved() {
}
bool GpuJpegDecodeAccelerator::Send(IPC::Message* message) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
return channel_->Send(message);
}
+void GpuJpegDecodeAccelerator::Initialize(
+ mojom::GpuJpegDecodeAcceleratorClientPtr client,
+ InitializeCallback callback) {
+ // TODO(c.padhi): see http://crbug.com/699255.
+ NOTIMPLEMENTED();
+}
+
+void GpuJpegDecodeAccelerator::Decode(mojom::JpegDecodeInfoPtr info) {
+ // TODO(c.padhi): see http://crbug.com/699255.
+ NOTIMPLEMENTED();
+}
+
+void GpuJpegDecodeAccelerator::Uninitialize() {
+ // TODO(c.padhi): see http://crbug.com/699255.
+ NOTIMPLEMENTED();
+}
+
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698