Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2905783002: Rename SendContextMenuEventForKey to ShowNonLocatedContextMenu (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/input/EventHandler.h ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/input/EventHandler.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp
index 731624bfcf1c7a13ac042921bfa12bee9e1a3daf..85aa0c06f3c9cba37e12e2f60dd74189df73e244 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp
@@ -1810,7 +1810,7 @@ static bool ShouldShowContextMenuAtSelection(const FrameSelection& selection) {
return selection.SelectionHasFocus();
}
-WebInputEventResult EventHandler::SendContextMenuEventForKey(
+WebInputEventResult EventHandler::ShowNonLocatedContextMenu(
Element* override_target_element) {
FrameView* view = frame_->View();
if (!view)
@@ -1881,7 +1881,7 @@ WebInputEventResult EventHandler::SendContextMenuEventForKey(
doc->UpdateHoverActiveState(request, result.InnerElement());
// The contextmenu event is a mouse event even when invoked using the
- // keyboard. This is required for web compatibility.
+ // keyboard or other methods. This is required for web compatibility.
WebInputEvent::Type event_type = WebInputEvent::kMouseDown;
if (frame_->GetSettings() &&
frame_->GetSettings()->GetShowContextMenuOnMouseUp())
« no previous file with comments | « third_party/WebKit/Source/core/input/EventHandler.h ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698