Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: content/browser/resource_request_body_browser_utils.cc

Issue 2905763002: Deduplicating CanReadRequestBody code. (Closed)
Patch Set: Tweaking content/browser/loader/DEPS Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/resource_request_body_browser_utils.cc
diff --git a/content/browser/resource_request_body_browser_utils.cc b/content/browser/resource_request_body_browser_utils.cc
new file mode 100644
index 0000000000000000000000000000000000000000..da30efe2461a766e8f7da971833990beaed5321a
--- /dev/null
+++ b/content/browser/resource_request_body_browser_utils.cc
@@ -0,0 +1,76 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/resource_request_body_browser_utils.h"
+
+#include "content/browser/child_process_security_policy_impl.h"
+#include "content/browser/site_instance_impl.h"
+#include "content/common/resource_request_body_impl.h"
+#include "content/public/browser/browser_context.h"
+#include "content/public/browser/storage_partition.h"
+#include "storage/browser/fileapi/file_system_context.h"
+
+namespace content {
+
+bool CanReadRequestBody(SiteInstance* site_instance,
+ const scoped_refptr<ResourceRequestBodyImpl>& body) {
+ int child_id = site_instance->GetProcess()->GetID();
+
+ StoragePartition* storage_partition = BrowserContext::GetStoragePartition(
+ site_instance->GetBrowserContext(), site_instance);
+ const storage::FileSystemContext* file_system_context =
+ storage_partition->GetFileSystemContext();
+
+ return CanReadRequestBody(child_id, file_system_context, body);
+}
+
+bool CanReadRequestBody(int child_id,
+ const storage::FileSystemContext* file_system_context,
+ const scoped_refptr<ResourceRequestBodyImpl>& body) {
+ if (!body)
+ return true;
+
+ ChildProcessSecurityPolicyImpl* security_policy =
+ ChildProcessSecurityPolicyImpl::GetInstance();
+ for (const ResourceRequestBodyImpl::Element& element : *body->elements()) {
+ switch (element.type()) {
+ case ResourceRequestBodyImpl::Element::TYPE_FILE:
+ if (!security_policy->CanReadFile(child_id, element.path()))
+ return false;
+ break;
+
+ case ResourceRequestBodyImpl::Element::TYPE_FILE_FILESYSTEM:
+ if (!security_policy->CanReadFileSystemFile(
+ child_id,
+ file_system_context->CrackURL(element.filesystem_url())))
+ return false;
+ break;
+
+ case ResourceRequestBodyImpl::Element::TYPE_DISK_CACHE_ENTRY:
+ // TYPE_DISK_CACHE_ENTRY can't be sent via IPC according to
+ // content/common/resource_messages.cc
+ NOTREACHED();
+ return false;
+
+ case ResourceRequestBodyImpl::Element::TYPE_BYTES:
+ case ResourceRequestBodyImpl::Element::TYPE_BYTES_DESCRIPTION:
+ // Data is self-contained within |body| - no need to check access.
+ break;
+
+ case ResourceRequestBodyImpl::Element::TYPE_BLOB:
+ // No need to validate - the unguessability of the uuid of the blob is a
+ // sufficient defense against access from an unrelated renderer.
+ break;
+
+ case ResourceRequestBodyImpl::Element::TYPE_UNKNOWN:
+ default:
+ // Fail safe - deny access.
+ NOTREACHED();
+ return false;
+ }
+ }
+ return true;
+}
+
+} // namespace content

Powered by Google App Engine
This is Rietveld 408576698