Deduplicating CanReadRequestBody code.

content/browser/frame_host/render_frame_proxy_host.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_proxy_host.h"
 
 #include <utility>
 
 #include "base/lazy_instance.h"
 #include "content/browser/bad_message.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/frame_host/cross_process_frame_connector.h"
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/frame_host/navigator.h"
 #include "content/browser/frame_host/render_frame_host_delegate.h"
 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
+#include "content/browser/resource_request_body_browser_utils.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/common/frame_messages.h"
 #include "content/common/frame_owner_properties.h"
 #include "content/common/resource_request_body_impl.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/storage_partition.h"
 #include "ipc/ipc_message.h"
 #include "storage/browser/fileapi/file_system_context.h"
 
 namespace content {
 
 namespace {
 
 // The (process id, routing id) pair that identifies one RenderFrameProxy.
 typedef std::pair<int32_t, int32_t> RenderFrameProxyHostID;
 typedef base::hash_map<RenderFrameProxyHostID, RenderFrameProxyHost*>
     RoutingIDFrameProxyMap;
 base::LazyInstance<RoutingIDFrameProxyMap>::DestructorAtExit
     g_routing_id_frame_proxy_map = LAZY_INSTANCE_INITIALIZER;
 
-// TODO(lukasza): https://crbug.com/726067: Remove code duplication - the
-// function below should be reused by RenderFrameHostImpl::OnBeginNavigation and
-// ResourceDispatcherHostImpl::ShouldServiceRequest.
-bool CanReadRequestBody(SiteInstance* site_instance,
-                        const scoped_refptr<ResourceRequestBodyImpl>& body) {
-  if (!body)
-    return true;
-
-  ChildProcessSecurityPolicyImpl* security_policy =
-      ChildProcessSecurityPolicyImpl::GetInstance();
-  int child_id = site_instance->GetProcess()->GetID();
-
-  StoragePartition* storage_partition = BrowserContext::GetStoragePartition(
-      site_instance->GetBrowserContext(), site_instance);
-  const storage::FileSystemContext* file_system_context =
-      storage_partition->GetFileSystemContext();
-
-  for (const ResourceRequestBodyImpl::Element& element : *body->elements()) {
-    switch (element.type()) {
-      case ResourceRequestBodyImpl::Element::TYPE_FILE:
-        if (!security_policy->CanReadFile(child_id, element.path()))
-          return false;
-        break;
-
-      case ResourceRequestBodyImpl::Element::TYPE_FILE_FILESYSTEM:
-        if (!security_policy->CanReadFileSystemFile(
-                child_id,
-                file_system_context->CrackURL(element.filesystem_url())))
-          return false;
-        break;
-
-      case ResourceRequestBodyImpl::Element::TYPE_DISK_CACHE_ENTRY:
-        // TYPE_DISK_CACHE_ENTRY can't be sent via IPC according to
-        // content/common/resource_messages.cc
-        NOTREACHED();
-        return false;
-
-      case ResourceRequestBodyImpl::Element::TYPE_BYTES:
-      case ResourceRequestBodyImpl::Element::TYPE_BYTES_DESCRIPTION:
-        // Data is self-contained within |body| - no need to check access.
-        break;
-
-      case ResourceRequestBodyImpl::Element::TYPE_BLOB:
-        // No need to validate - the unguessability of the uuid of the blob is a
-        // sufficient defense against access from an unrelated renderer.
-        break;
-
-      case ResourceRequestBodyImpl::Element::TYPE_UNKNOWN:
-      default:
-        // Fail safe - deny access.
-        NOTREACHED();
-        return false;
-    }
-  }
-  return true;
-}
-
 }  // namespace
 
 // static
 RenderFrameProxyHost* RenderFrameProxyHost::FromID(int process_id,
                                                    int routing_id) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   RoutingIDFrameProxyMap* frames = g_routing_id_frame_proxy_map.Pointer();
   RoutingIDFrameProxyMap::iterator it = frames->find(
       RenderFrameProxyHostID(process_id, routing_id));
   return it == frames->end() ? NULL : it->second;
@@ skipping 309 matching lines @@
 
   target_rfh->AdvanceFocus(type, source_proxy);
 }
 
 void RenderFrameProxyHost::OnFrameFocused() {
   frame_tree_node_->current_frame_host()->delegate()->SetFocusedFrame(
       frame_tree_node_, GetSiteInstance());
 }
 
 }  // namespace content