third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp - Issue 2905753002: [DMC #17] Make TextMatchMarkers constructible in single step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp

Issue 2905753002: [DMC #17] Make TextMatchMarkers constructible in single step (Closed)

Patch Set: Fix build error Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/markers/DocumentMarkerTest.cpp ('K') | « third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h ('k') | third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImplTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp b/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp

index 7cd3231faca24f9d43c355ee35f9afe89475fce1..18a5d75a0fb6d6ac386509881b2c9e6aa27561d6 100644

--- a/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp

@@ -22,8 +22,8 @@ bool TextMatchMarkerListImpl::IsEmpty() const {

}

void TextMatchMarkerListImpl::Add(DocumentMarker* marker) {

- DocumentMarkerListEditor::AddMarkerWithoutMergingOverlapping(

- &markers_, TextMatchMarker::Create(*marker));

+ DocumentMarkerListEditor::AddMarkerWithoutMergingOverlapping(&markers_,

+ marker);

}

void TextMatchMarkerListImpl::Clear() {