third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp - Issue 2905753002: [DMC #17] Make TextMatchMarkers constructible in single step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

Issue 2905753002: [DMC #17] Make TextMatchMarkers constructible in single step (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarker.h ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerTest.cpp » ('j') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

index cf2be572e4bd24cec84531d65063ea0b1a82bc5c..18d25c08b5aa3d098e27b13be317dccbe1340309 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

@@ -162,9 +162,9 @@ void DocumentMarkerController::AddTextMatchMarker(

for (TextIterator marked_text(range.StartPosition(), range.EndPosition());

!marked_text.AtEnd(); marked_text.Advance()) {

AddMarker(marked_text.CurrentContainer(),

- new DocumentMarker(marked_text.StartOffsetInCurrentContainer(),

- marked_text.EndOffsetInCurrentContainer(),

- match_status));

+ new TextMatchMarker(marked_text.StartOffsetInCurrentContainer(),

+ marked_text.EndOffsetInCurrentContainer(),

+ match_status));

}

// Don't invalidate tickmarks here. TextFinder invalidates tickmarks using a

// throttling algorithm. crbug.com/6819.