[WebPayments] Disabling done button when form invalid

chrome/browser/ui/views/payments/payment_request_browsertest_base.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/payment_request_browsertest_base.h"
 
 #include <algorithm>
 #include <iostream>
 #include <memory>
 #include <string>
@@ skipping 37 matching lines @@
 #include "ui/gfx/animation/test_animation_delegate.h"
 #include "ui/gfx/geometry/point.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/controls/styled_label.h"
 
 namespace payments {
 
 namespace {
 const auto kBillingAddressType = autofill::ADDRESS_BILLING_LINE1;
+
+// This is preferred to SelectValue, since only SetSelectedRow fires the events
+// as if done by a user.
+void SetComboboxRowForValue(views::Combobox* combobox,

[Mathieu, 2017/05/29 16:45:36]

nit: *SelectComboboxRowForValue?

[tmartino, 2017/05/29 21:06:58]

Done

+                            const base::string16& text) {
+  int i;
+  for (i = 0; i < combobox->GetRowCount(); i++) {
+    if (combobox->GetTextForRow(i) == text)
+      break;
+  }
+  DCHECK(i < combobox->GetRowCount()) << "Combobox does not contain " << text;
+  combobox->SetSelectedRow(0);

[Mathieu, 2017/05/29 16:45:36]

The SelectBillingAddress code seems to get away with just 1 call to
SetSelectedRow, then OnBlur. Can we do the same?

[tmartino, 2017/05/29 21:06:58]

Yup, done.

+  combobox->SetSelectedRow(i);
+
+  // Hit enter twice to trigger events.

[Mathieu, 2017/05/29 16:45:36]

Are we doing this to make sure OnBlur is called on the combobox? If so, could we
call combobox->OnBlur() directly?

[tmartino, 2017/05/29 21:06:58]

n/a anymore

+  ui::KeyEvent enter_event(ui::ET_KEY_PRESSED, ui::VKEY_RETURN, 0);
+  LOG(ERROR) << "Pressing enter...";

[Mathieu, 2017/05/29 16:45:36]

plz remove :)

[tmartino, 2017/05/29 21:06:58]

n/a

+  combobox->OnKeyPressed(enter_event);
+  LOG(ERROR) << "Pressing enter...";
+  combobox->OnKeyPressed(enter_event);
+  LOG(ERROR) << "Done pressing enter...";
+}
+
 }  // namespace
 
 PersonalDataLoadedObserverMock::PersonalDataLoadedObserverMock() {}
 PersonalDataLoadedObserverMock::~PersonalDataLoadedObserverMock() {}
 
 PaymentRequestBrowserTestBase::PaymentRequestBrowserTestBase(
     const std::string& test_file_path)
     : test_file_path_(test_file_path),
       delegate_(nullptr),
       is_incognito_(false),
@@ skipping 496 matching lines @@
   return textfield->text();
 }
 
 void PaymentRequestBrowserTestBase::SetEditorTextfieldValue(
     const base::string16& value,
     autofill::ServerFieldType type) {
   ValidatingTextfield* textfield =
       static_cast<ValidatingTextfield*>(delegate_->dialog_view()->GetViewByID(
           EditorViewController::GetInputFieldViewId(type)));
   DCHECK(textfield);
-  textfield->SetText(value);
-  textfield->OnContentsChanged();
+  textfield->SetText(base::string16());
+  textfield->InsertText(value);
   textfield->OnBlur();
 }
 
 base::string16 PaymentRequestBrowserTestBase::GetComboboxValue(
     autofill::ServerFieldType type) {
   ValidatingCombobox* combobox =
       static_cast<ValidatingCombobox*>(delegate_->dialog_view()->GetViewByID(
           EditorViewController::GetInputFieldViewId(type)));
   DCHECK(combobox);
   return combobox->model()->GetItemAt(combobox->selected_index());
 }
 
 void PaymentRequestBrowserTestBase::SetComboboxValue(
     const base::string16& value,
     autofill::ServerFieldType type) {
   ValidatingCombobox* combobox =
       static_cast<ValidatingCombobox*>(delegate_->dialog_view()->GetViewByID(
           EditorViewController::GetInputFieldViewId(type)));
   DCHECK(combobox);
-  combobox->SelectValue(value);
-  combobox->OnContentsChanged();
+  SetComboboxRowForValue(combobox, value);
   combobox->OnBlur();
 }
 
 void PaymentRequestBrowserTestBase::SelectBillingAddress(
     const std::string& billing_address_id) {
+  LOG(ERROR) << "Setting billing address";

[Mathieu, 2017/05/29 16:45:36]

please fix

[tmartino, 2017/05/29 21:06:58]

Done

   views::Combobox* address_combobox(
       static_cast<views::Combobox*>(dialog_view()->GetViewByID(
           EditorViewController::GetInputFieldViewId(kBillingAddressType))));
   ASSERT_NE(address_combobox, nullptr);
   autofill::AddressComboboxModel* address_combobox_model(
       static_cast<autofill::AddressComboboxModel*>(address_combobox->model()));
   address_combobox->SetSelectedRow(
       address_combobox_model->GetIndexOfIdentifier(billing_address_id));
   address_combobox->OnBlur();
 }
@@ skipping 163 matching lines @@
       break;
     case DialogEvent::NOT_SUPPORTED_ERROR:
       out << "NOT_SUPPORTED_ERROR";
       break;
     case DialogEvent::ABORT_CALLED:
       out << "ABORT_CALLED";
       break;
   }
   return out;
 }