[WebPayments] Disabling done button when form invalid

chrome/browser/ui/views/payments/editor_view_controller.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_EDITOR_VIEW_CONTROLLER_H_
 #define CHROME_BROWSER_UI_VIEWS_PAYMENTS_EDITOR_VIEW_CONTROLLER_H_
 
 #include <map>
 #include <memory>
 #include <tuple>
@@ skipping 96 matching lines @@
 
   // Returns the View ID that can be used to lookup the input field for |type|.
   static int GetInputFieldViewId(autofill::ServerFieldType type);
 
  protected:
   // Create a header view to be inserted before all fields.
   virtual std::unique_ptr<views::View> CreateHeaderView();
   // |focusable_field| is to be set with a pointer to the view that should get
   // default focus within the custom view. |valid| should be set to the initial
   // validity state of the custom view.
   virtual std::unique_ptr<views::View> CreateCustomFieldView(

[Mathieu, 2017/05/29 16:45:36]

Can you add a comment here, saying that if a custom view requires model
validation, they should  make sure their fields are tracked in |text_fields_| or
|comboboxes_| (e.g., by using CreateComboboxForField).

[tmartino, 2017/05/29 21:06:58]

Done

       autofill::ServerFieldType type,
       views::View** focusable_field,
       bool* valid);
   // Create an extra view to go to the right of the field with |type|, which
   // can either be a textfield, combobox, or custom view.
   virtual std::unique_ptr<views::View> CreateExtraViewForField(
       autofill::ServerFieldType type);
 
   // Returns the field definitions used to build the UI.
   virtual std::vector<EditorField> GetFieldDefinitions() = 0;
   virtual base::string16 GetInitialValueForType(
       autofill::ServerFieldType type) = 0;
   // Validates the data entered and attempts to save; returns true on success.
   virtual bool ValidateModelAndSave() = 0;
+
   // Creates a ValidationDelegate which knows how to validate for a given
   // |field| definition.
   virtual std::unique_ptr<ValidationDelegate> CreateValidationDelegate(
       const EditorField& field) = 0;
   virtual std::unique_ptr<ui::ComboboxModel> GetComboboxModelForType(
       const autofill::ServerFieldType& type) = 0;
 
+  // Returns true if all fields are valid. Relies on cached validity values,

[Mathieu, 2017/05/29 16:45:36]

no cache?

[tmartino, 2017/05/29 21:06:58]

Done

+  // which are computed once for all fields at init-time, and subsequently
+  // upon user interactions on a per-field basis.
+  bool ValidateModel();
+
   // PaymentRequestSheetController;
   std::unique_ptr<views::Button> CreatePrimaryButton() override;
   void FillContentView(views::View* content_view) override;
 
   // views::ComboboxListener:
   void OnPerformAction(views::Combobox* combobox) override;
 
   // Update the editor view by removing all it's child views and recreating
   // the input fields returned by GetFieldDefinitions. Note that
   // CreateEditorView MUST have been called at least once before calling
@@ skipping 46 matching lines @@
 
   // Identifies where to go back when the editing completes successfully.
   BackNavigationType back_navigation_type_;
 
   DISALLOW_COPY_AND_ASSIGN(EditorViewController);
 };
 
 }  // namespace payments
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PAYMENTS_EDITOR_VIEW_CONTROLLER_H_