Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1423)

Unified Diff: components/translate/core/browser/translate_ui_delegate.h

Issue 290573013: LanguageState should be owned by TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding TBR for CL Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ui_delegate.h
diff --git a/components/translate/core/browser/translate_ui_delegate.h b/components/translate/core/browser/translate_ui_delegate.h
index ab6986e3f32619b8452bc7f2b440e23eb296d26b..2ab8068272d72f64e4f2065711b1a84df8e225aa 100644
--- a/components/translate/core/browser/translate_ui_delegate.h
+++ b/components/translate/core/browser/translate_ui_delegate.h
@@ -10,6 +10,7 @@
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
#include "base/strings/string16.h"
#include "components/translate/core/common/translate_errors.h"
@@ -25,8 +26,7 @@ class TranslateUIDelegate {
public:
enum { NO_INDEX = -1, };
- TranslateUIDelegate(TranslateClient* translate_client,
- TranslateManager* translate_manager,
+ TranslateUIDelegate(const base::WeakPtr<TranslateManager>& translate_manager,
const std::string& original_language,
const std::string& target_language);
virtual ~TranslateUIDelegate();
@@ -98,9 +98,8 @@ class TranslateUIDelegate {
// associated with the current page.
std::string GetPageHost();
- TranslateClient* translate_client_;
TranslateDriver* translate_driver_;
- TranslateManager* translate_manager_;
+ base::WeakPtr<TranslateManager> translate_manager_;
typedef std::pair<std::string, base::string16> LanguageNamePair;
« no previous file with comments | « components/translate/core/browser/translate_manager.cc ('k') | components/translate/core/browser/translate_ui_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698