Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: components/translate/content/browser/content_translate_driver.h

Issue 290573013: LanguageState should be owned by TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding TBR for CL Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/content/browser/content_translate_driver.h
diff --git a/components/translate/content/browser/content_translate_driver.h b/components/translate/content/browser/content_translate_driver.h
index 1d3112d46c5605b85398d6bdb3bd62c5ac02d418..7f686f3462c6e7e42d0b0dac474e2e988cc21711 100644
--- a/components/translate/content/browser/content_translate_driver.h
+++ b/components/translate/content/browser/content_translate_driver.h
@@ -5,12 +5,10 @@
#ifndef COMPONENTS_TRANSLATE_CONTENT_BROWSER_CONTENT_TRANSLATE_DRIVER_H_
#define COMPONENTS_TRANSLATE_CONTENT_BROWSER_CONTENT_TRANSLATE_DRIVER_H_
+#include "base/basictypes.h"
#include "components/translate/core/browser/translate_driver.h"
-#include "components/translate/core/browser/language_state.h"
-
namespace content {
-struct LoadCommittedDetails;
class NavigationController;
class WebContents;
}
@@ -38,14 +36,10 @@ class ContentTranslateDriver : public TranslateDriver {
// Sets the Observer. Calling this method is optional.
void set_observer(Observer* observer) { observer_ = observer; }
- // Must be called on navigations.
- void DidNavigate(const content::LoadCommittedDetails& details);
-
// TranslateDriver methods.
virtual void OnIsPageTranslatedChanged() OVERRIDE;
virtual void OnTranslateEnabledChanged() OVERRIDE;
virtual bool IsLinkNavigation() OVERRIDE;
- virtual LanguageState& GetLanguageState() OVERRIDE;
virtual void TranslatePage(const std::string& translate_script,
const std::string& source_lang,
const std::string& target_lang) OVERRIDE;
@@ -63,7 +57,6 @@ class ContentTranslateDriver : public TranslateDriver {
// The navigation controller of the tab we are associated with.
content::NavigationController* navigation_controller_;
- LanguageState language_state_;
Observer* observer_;
DISALLOW_COPY_AND_ASSIGN(ContentTranslateDriver);

Powered by Google App Engine
This is Rietveld 408576698