chrome/browser/ui/cocoa/browser_window_controller.mm - Issue 290573013: LanguageState should be owned by TranslateManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 290573013: LanguageState should be owned by TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding TBR for CL Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm

index 5793c5c0c4c7d685c1a7ad25c7fac7ca77022f30..16b921965cbfa008f493364d9af32c7b9ed52904 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm

@@ -79,6 +79,7 @@

#include "chrome/common/extensions/command.h"

#include "chrome/common/url_constants.h"

#include "components/signin/core/common/profile_management_switches.h"

+#include "components/translate/core/browser/translate_manager.h"

#include "components/translate/core/browser/translate_ui_delegate.h"

#include "components/web_modal/web_contents_modal_dialog_manager.h"

#include "content/public/browser/render_view_host.h"

@@ -1788,8 +1789,7 @@ enum {

contents, &sourceLanguage, &targetLanguage);

scoped_ptr<TranslateUIDelegate> uiDelegate(new TranslateUIDelegate(

- ChromeTranslateClient::FromWebContents(contents),

- ChromeTranslateClient::GetManagerFromWebContents(contents),

+ ChromeTranslateClient::GetManagerFromWebContents(contents)->GetWeakPtr(),

sourceLanguage,

targetLanguage));

scoped_ptr<TranslateBubbleModel> model(