Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/translate/core/browser/translate_infobar_delegate.cc

Issue 290573013: LanguageState should be owned by TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tested for asan issue on linux Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/core/browser/translate_driver.h ('k') | components/translate/core/browser/translate_manager.h » ('j') | components/translate/core/browser/translate_ui_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/browser/translate_infobar_delegate.cc
diff --git a/components/translate/core/browser/translate_infobar_delegate.cc b/components/translate/core/browser/translate_infobar_delegate.cc
index 69ff12a9243cc19802bbf6e9b751684c8796e4f6..f24ec7b9140e45df88881cabe2e894a23d885d99 100644
--- a/components/translate/core/browser/translate_infobar_delegate.cc
+++ b/components/translate/core/browser/translate_infobar_delegate.cc
@@ -78,8 +78,7 @@ void TranslateInfoBarDelegate::Create(
TranslateClient* translate_client = translate_manager->translate_client();
if (((step == translate::TRANSLATE_STEP_AFTER_TRANSLATE) ||
(step == translate::TRANSLATE_STEP_TRANSLATING)) &&
- translate_client->GetTranslateDriver()->GetLanguageState()
- .InTranslateNavigation()) {
+ translate_manager->GetLanguageState().InTranslateNavigation()) {
return;
}
@@ -323,7 +322,7 @@ TranslateInfoBarDelegate::TranslateInfoBarDelegate(
step_(step),
background_animation_(NONE),
ui_delegate_(translate_manager->translate_client(),
- translate_manager.get(),
+ translate_manager,
original_language,
target_language),
translate_manager_(translate_manager),
« no previous file with comments | « components/translate/core/browser/translate_driver.h ('k') | components/translate/core/browser/translate_manager.h » ('j') | components/translate/core/browser/translate_ui_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698