chrome/browser/ui/views/translate/translate_bubble_view.cc - Issue 290573013: LanguageState should be owned by TranslateManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 290573013: LanguageState should be owned by TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tested for asan issue on linux Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/translate/translate_bubble_view.cc

diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc

index 19088730aed5d9cead1167a59e757c9f995628a2..c9bce8c8ac2f1084b8dc09003d6c4b4cf072256e 100644

--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc

+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc

@@ -143,7 +143,8 @@ void TranslateBubbleView::ShowBubble(views::View* anchor_view,

scoped_ptr<TranslateUIDelegate> ui_delegate(new TranslateUIDelegate(

ChromeTranslateClient::FromWebContents(web_contents),

- ChromeTranslateClient::GetManagerFromWebContents(web_contents),

+ ChromeTranslateClient::GetManagerFromWebContents(web_contents)

+ ->GetWeakPtr(),

source_language,

target_language));

scoped_ptr<TranslateBubbleModel> model(