Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 290573013: LanguageState should be owned by TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tested for asan issue on linux Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | components/translate/core/browser/translate_ui_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 5793c5c0c4c7d685c1a7ad25c7fac7ca77022f30..033a1ccb0a2e2539bd6dbcd3b953201443665b44 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -79,6 +79,7 @@
#include "chrome/common/extensions/command.h"
#include "chrome/common/url_constants.h"
#include "components/signin/core/common/profile_management_switches.h"
+#include "components/translate/core/browser/translate_manager.h"
#include "components/translate/core/browser/translate_ui_delegate.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h"
#include "content/public/browser/render_view_host.h"
@@ -1789,7 +1790,7 @@ enum {
scoped_ptr<TranslateUIDelegate> uiDelegate(new TranslateUIDelegate(
ChromeTranslateClient::FromWebContents(contents),
- ChromeTranslateClient::GetManagerFromWebContents(contents),
+ ChromeTranslateClient::GetManagerFromWebContents(contents)->GetWeakPtr(),
sourceLanguage,
targetLanguage));
scoped_ptr<TranslateBubbleModel> model(
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | components/translate/core/browser/translate_ui_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698