Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: chrome/browser/translate/translate_manager_render_view_host_unittest.cc

Issue 290573013: LanguageState should be owned by TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tested for asan issue on linux Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager_render_view_host_unittest.cc
diff --git a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
index 254f435d6e61d3ad21c8183e3324197286405c9b..d07b9d27bfa7381253cbeb800ef5c608739a5eca 100644
--- a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
+++ b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
@@ -384,11 +384,12 @@ class MockTranslateBubbleFactory : public TranslateBubbleFactory {
chrome_translate_client->GetLanguageState().original_language();
std::string target_language = TranslateDownloadManager::GetLanguageCode(
g_browser_process->GetApplicationLocale());
- scoped_ptr<TranslateUIDelegate> ui_delegate(
- new TranslateUIDelegate(chrome_translate_client,
- chrome_translate_client->GetTranslateManager(),
- source_language,
- target_language));
+
+ scoped_ptr<TranslateUIDelegate> ui_delegate(new TranslateUIDelegate(
+ chrome_translate_client,
+ chrome_translate_client->GetTranslateManager()->GetWeakPtr(),
+ source_language,
+ target_language));
model_.reset(new TranslateBubbleModelImpl(step, ui_delegate.Pass()));
}

Powered by Google App Engine
This is Rietveld 408576698