Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: chrome/browser/translate/translate_tab_helper.h

Issue 290573013: LanguageState should be owned by TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Inlining the DidNavigate function Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_
6 #define CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_ 6 #define CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 11 matching lines...) Expand all
22 #include "base/lazy_instance.h" 22 #include "base/lazy_instance.h"
23 #include "base/synchronization/lock.h" 23 #include "base/synchronization/lock.h"
24 #include "base/task_runner.h" 24 #include "base/task_runner.h"
25 #endif 25 #endif
26 26
27 namespace base { 27 namespace base {
28 class File; 28 class File;
29 } 29 }
30 30
31 namespace content { 31 namespace content {
32 struct LoadCommittedDetails;
32 class BrowserContext; 33 class BrowserContext;
34 class NavigationController;
droger 2014/05/20 07:43:07 Is this declaration necessary? I don't see where t
nshaik 2014/05/20 22:33:53 Done.
33 class WebContents; 35 class WebContents;
34 } 36 }
35 37
36 struct LanguageDetectionDetails; 38 struct LanguageDetectionDetails;
37 class PrefService; 39 class PrefService;
38 class TranslateAcceptLanguages; 40 class TranslateAcceptLanguages;
39 class TranslatePrefs; 41 class TranslatePrefs;
40 class TranslateManager; 42 class TranslateManager;
41 43
42 class TranslateTabHelper 44 class TranslateTabHelper
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 168
167 // Necessary for binding the callback to HandleCLDDataRequest on the blocking 169 // Necessary for binding the callback to HandleCLDDataRequest on the blocking
168 // pool and for delaying translation initialization until the page has 170 // pool and for delaying translation initialization until the page has
169 // finished loading on a reload. 171 // finished loading on a reload.
170 base::WeakPtrFactory<TranslateTabHelper> weak_pointer_factory_; 172 base::WeakPtrFactory<TranslateTabHelper> weak_pointer_factory_;
171 173
172 DISALLOW_COPY_AND_ASSIGN(TranslateTabHelper); 174 DISALLOW_COPY_AND_ASSIGN(TranslateTabHelper);
173 }; 175 };
174 176
175 #endif // CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_ 177 #endif // CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698