Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 290573010: Clean up in browser side of allowFileSystem. [chromium] (4/4) (Closed)

Created:
6 years, 7 months ago by Xi Han
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@asyn_codereview
Visibility:
Public.

Description

Clean up in browser side of allowFileSystem. Remove unused part for shared worker. Solve conflicts from rebase. Conflicts: chrome/renderer/content_settings_observer.cc chrome/renderer/content_settings_observer.h BUG=343382 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272850

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M chrome/renderer/content_settings_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/content_settings_observer.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/renderer/worker_permission_client_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/worker_permission_client_proxy.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/worker/shared_worker_permission_client_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/worker/shared_worker_permission_client_proxy.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Xi Han
6 years, 7 months ago (2014-05-16 20:23:39 UTC) #1
Xi Han
Currently there are 4 CLs for filesystem permission implementation for WebView, and this is the ...
6 years, 7 months ago (2014-05-16 21:57:36 UTC) #2
kinuko
lgtm
6 years, 7 months ago (2014-05-19 09:03:31 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-19 13:23:16 UTC) #4
Xi Han
The CQ bit was checked by hanxi@chromium.org
6 years, 7 months ago (2014-05-26 01:44:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hanxi@chromium.org/290573010/40001
6 years, 7 months ago (2014-05-26 01:45:48 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 16:34:11 UTC) #7
Message was sent while issue was closed.
Change committed as 272850

Powered by Google App Engine
This is Rietveld 408576698