Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 290573007: cc: Move gpu rasterization flag from tree-impl to tree-host-impl. (Closed)

Created:
6 years, 7 months ago by alokp
Modified:
6 years, 7 months ago
Reviewers:
reveman, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, nduca, ernstm
Visibility:
Public.

Description

cc: Move gpu rasterization flag from tree-impl to tree-host-impl. This will allow us to get rid of two live rasterizers and the rasterizer delegate. BUG=367200 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271755

Patch Set 1 #

Patch Set 2 : prevent checkerboard and flash on switch #

Patch Set 3 : fixed LTHI memory policy #

Patch Set 4 : updated unittests #

Total comments: 1

Patch Set 5 : added unittests #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -67 lines) Patch
M cc/layers/picture_layer_impl.h View 2 chunks +2 lines, -5 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 3 4 5 6 6 chunks +8 lines, -10 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 3 4 5 6 3 chunks +31 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 3 chunks +15 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 3 4 5 2 chunks +21 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 4 5 3 chunks +12 lines, -30 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 2 3 4 5 2 chunks +1 line, -3 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 3 4 5 3 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
alokp
I will rip out the rasterizer delegate in the next patch. https://codereview.chromium.org/290573007/diff/60001/cc/layers/picture_layer_impl.cc File cc/layers/picture_layer_impl.cc (left): ...
6 years, 7 months ago (2014-05-16 20:08:27 UTC) #1
enne (OOO)
It does make things slightly more simple to do this on the LTHI, but it ...
6 years, 7 months ago (2014-05-16 21:33:30 UTC) #2
alokp
OK. I added a couple unittests. Please check if this is what you had in ...
6 years, 7 months ago (2014-05-19 21:30:53 UTC) #3
enne (OOO)
lgtm
6 years, 7 months ago (2014-05-19 21:36:42 UTC) #4
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 7 months ago (2014-05-19 22:45:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/290573007/100001
6 years, 7 months ago (2014-05-19 22:46:22 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 01:28:22 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 01:47:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155219)
6 years, 7 months ago (2014-05-20 01:47:19 UTC) #9
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 7 months ago (2014-05-20 03:45:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/290573007/100001
6 years, 7 months ago (2014-05-20 03:46:05 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 06:16:50 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 07:05:10 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155295)
6 years, 7 months ago (2014-05-20 07:05:10 UTC) #14
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 7 months ago (2014-05-20 13:44:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/290573007/100001
6 years, 7 months ago (2014-05-20 13:44:47 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 14:02:41 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 14:16:12 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155295)
6 years, 7 months ago (2014-05-20 14:16:12 UTC) #19
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 7 months ago (2014-05-20 17:04:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/290573007/100001
6 years, 7 months ago (2014-05-20 17:04:57 UTC) #21
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 7 months ago (2014-05-20 17:14:27 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/290573007/120001
6 years, 7 months ago (2014-05-20 17:17:53 UTC) #23
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 21:22:08 UTC) #24
Message was sent while issue was closed.
Change committed as 271755

Powered by Google App Engine
This is Rietveld 408576698