Make tooltips toplevel windows on Linux

chrome/browser/ui/views/chrome_views_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/chrome_views_delegate.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/strings/string_util.h"
@@ skipping 244 matching lines @@
   if (params->opacity == views::Widget::InitParams::INFER_OPACITY)
     params->opacity = GetOpacityForInitParams(*params);
 
   // If we already have a native_widget, we don't have to try to come
   // up with one.
   if (params->native_widget)
     return;
 
 #if defined(USE_AURA) && !defined(OS_CHROMEOS)
   bool use_non_toplevel_window =
-      params->parent && params->type != views::Widget::InitParams::TYPE_MENU;
+      params->parent &&
+      params->type != views::Widget::InitParams::TYPE_MENU &&
+      params->type != views::Widget::InitParams::TYPE_TOOLTIP;
 
 #if defined(OS_WIN)
   // On desktop Linux Chrome must run in an environment that supports a variety
   // of window managers, some of which do not play nicely with parts of our UI
   // that have specific expectations about window sizing and placement. For this
   // reason windows opened as top level (!params.child) are always constrained
   // by the browser frame, so we can position them correctly. This has some
   // negative side effects, like dialogs being clipped by the browser frame, but
   // the side effects are not as bad as the poor window manager interactions. On
   // Windows however these WM interactions are not an issue, so we open windows
@@ skipping 38 matching lines @@
   if (params->context)
     params->context = params->context->GetRootWindow();
   DCHECK(params->parent || params->context || !params->child)
       << "Please provide a parent or context for this widget.";
   if (!params->parent && !params->context)
     params->context = ash::Shell::GetPrimaryRootWindow();
 #elif defined(USE_AURA)
   // While the majority of the time, context wasn't plumbed through due to the
   // existence of a global WindowTreeClient, if this window is toplevel, it's
   // possible that there is no contextual state that we can use.
-  if (params->parent == NULL &&
-      params->context == NULL &&
-      !params->child &&
-      params->type != views::Widget::InitParams::TYPE_TOOLTIP) {
+  if (params->parent == NULL && params->context == NULL && !params->child) {
     // We need to make a decision about where to place this window based on the
     // desktop type.
     switch (chrome::GetActiveDesktop()) {
       case chrome::HOST_DESKTOP_TYPE_NATIVE:
         // If we're native, we should give this window its own toplevel desktop
         // widget.
         params->native_widget = new views::DesktopNativeWidgetAura(delegate);
         break;
 #if defined(USE_ASH)
       case chrome::HOST_DESKTOP_TYPE_ASH:
         // If we're in ash, give this window the context of the main monitor.
         params->context = ash::Shell::GetPrimaryRootWindow();
         break;
 #endif
       default:
         NOTREACHED();
     }
   } else if (use_non_toplevel_window) {
     views::NativeWidgetAura* native_widget =
         new views::NativeWidgetAura(delegate);
     if (params->parent) {
       Profile* parent_profile = reinterpret_cast<Profile*>(
           params->parent->GetNativeWindowProperty(Profile::kProfileKey));
       native_widget->SetNativeWindowProperty(Profile::kProfileKey,
                                              parent_profile);
     }
     params->native_widget = native_widget;
-  } else if (params->type != views::Widget::InitParams::TYPE_TOOLTIP) {
+  } else {
     // TODO(erg): Once we've threaded context to everywhere that needs it, we
     // should remove this check here.
     gfx::NativeView to_check =
         params->context ? params->context : params->parent;
     if (chrome::GetHostDesktopTypeForNativeView(to_check) ==
         chrome::HOST_DESKTOP_TYPE_NATIVE) {
       params->native_widget = new views::DesktopNativeWidgetAura(delegate);
     }
   }
 #endif
@@ skipping 54 matching lines @@
 }
 #endif
 
 #if !defined(USE_AURA) && !defined(USE_CHROMEOS)
 views::Widget::InitParams::WindowOpacity
 ChromeViewsDelegate::GetOpacityForInitParams(
     const views::Widget::InitParams& params) {
   return views::Widget::InitParams::OPAQUE_WINDOW;
 }
 #endif