third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h - Issue 2905633002: Bind framebuffer to fbo_ object before readPixels, rather than multisample_fbo_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h

Issue 2905633002: Bind framebuffer to fbo_ object before readPixels, rather than multisample_fbo_ (Closed)

Patch Set: Resolve crash issue, need run releaseCallback once in case Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp ('K') | « third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h

diff --git a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h

index c231f0913a2f385f6590b534634669d62eb0ab39..3987824eeda9033b65716ee60ed0af007055c53e 100644

--- a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h

+++ b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h

@@ -214,8 +214,18 @@ class GLES2InterfaceForTests : public gpu::gles2::GLES2InterfaceStub,

}

void GetIntegerv(GLenum pname, GLint* value) override {

- if (pname == GL_MAX_TEXTURE_SIZE)

- *value = 1024;

+ switch (pname) {

+ case GL_DRAW_FRAMEBUFFER_BINDING:

+ *value = state_.draw_framebuffer_binding;

+ break;

+ case GL_READ_FRAMEBUFFER_BINDING:

+ *value = state_.read_framebuffer_binding;

+ break;

+ case GL_MAX_TEXTURE_SIZE:

+ *value = 1024;

+ default:

+ break;

+ }

}

void GenMailboxCHROMIUM(GLbyte* mailbox) override {