Defer style recalc when inserting extension stylesheets.

Defer style recalc when inserting extension stylesheets.

StyleEngine::addAuthorSheet, used when injecting stylesheets from extensions,
was doing a synchronous style recalc. Adding two stylesheets in a row would
cause two style recalcs. Do a deferred style recalc instead.

BUG=374901, 374162
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174424

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174555

[rune, 2014-05-19 21:12:15]

It might be possible to add an extensions test to chromium to check that we
batch css insertions once this change is rolled.

[ojan, 2014-05-20 03:18:15]

lgtm

Something we've been doing recently for these kinds of changes is to try to test
them at the Blink API layer. So, you could write a unittest for
WebDocument::insertStyleSheet. We don't have any unittests for WebDocument that
I can find, but you can probably work off of the WebFrameTest cases. Mind giving
that a shot?

[rune, 2014-05-20 12:02:15]

On 2014/05/20 03:18:15, ojan wrote:
> lgtm
> 
> Something we've been doing recently for these kinds of changes is to try to
test
> them at the Blink API layer. So, you could write a unittest for
> WebDocument::insertStyleSheet. We don't have any unittests for WebDocument
that
> I can find, but you can probably work off of the WebFrameTest cases. Mind
giving
> that a shot?

Done. PTAL.

[ojan, 2014-05-20 19:23:12]

lgtm

[commit-bot: I haz the power, 2014-05-20 19:23:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rune@opera.com/290563007/40001

[commit-bot: I haz the power, 2014-05-20 20:58:39]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/8320)

[rune, 2014-05-20 21:56:20]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-05-20 21:56:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rune@opera.com/290563007/60001

[commit-bot: I haz the power, 2014-05-20 23:21:07]

Change committed as 174424

[rune, 2014-05-21 12:18:18]

https://codereview.chromium.org/290563007/diff/80001/Source/web/tests/WebDocu...
File Source/web/tests/WebDocumentTest.cpp (right):

https://codereview.chromium.org/290563007/diff/80001/Source/web/tests/WebDocu...
Source/web/tests/WebDocumentTest.cpp:32:
webViewHelper.initializeAndLoad("about:blank");
See https://code.google.com/p/chromium/issues/detail?id=375728

Using this as a work-around as about:blank also contains a body element.

[rune, 2014-05-21 12:18:41]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-05-21 17:49:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rune@opera.com/290563007/80001

[commit-bot: I haz the power, 2014-05-22 06:08:35]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/9170)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8986)

[commit-bot: I haz the power, 2014-05-22 12:09:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 12:09:36]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/9170)

[rune, 2014-05-22 12:32:54]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-05-22 12:33:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rune@opera.com/290563007/80001

[commit-bot: I haz the power, 2014-05-22 14:24:26]

Change committed as 174555