Issue 290563005: Do SetNeedsCommit() instead of Composite() in threaded mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 290563005: Do SetNeedsCommit() instead of Composite() in threaded mode. (Closed)

Created:
6 years, 7 months ago by danakj

Modified:
6 years, 7 months ago

Reviewers:
enne (OOO), piman

CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do SetNeedsCommit() instead of Composite() in threaded mode. R=enne@chromium.org, piman@chromium.org, enne, piman BUG=374287 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271098

Patch Set 1 #

Patch Set 2 : composite: . #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -11 lines)			Patch
M	cc/trees/layer_tree_host.cc	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
M	content/renderer/gpu/render_widget_compositor.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/gpu/render_widget_compositor.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/compositor/compositor.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/290563005/40001

6 years, 7 months ago (2014-05-16 19:54:42 UTC) #5

danakj

6 years, 7 months ago (2014-05-16 21:30:16 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r271098 (presubmit successful).

Expand Messages | Collapse Messages