src/crankshaft/hydrogen.cc - Issue 2905623003: [turbofan] Speculatively optimize string character access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2905623003: [turbofan] Speculatively optimize string character access. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index 62d730d10a51d4b145f8c0a4a4fb0ac6dabe9168..d8bbd5736d96670cf94fe7283da9dd1ac10e049b 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -8351,7 +8351,7 @@ bool HOptimizedGraphBuilder::TryInlineBuiltinMethodCall(

}

case kStringCharCodeAt:

case kStringCharAt:

- if (argument_count == 2) {

+ if (argument_count == 2 && isolate()->IsStringBoundsCheckIntact()) {

HValue* index = Pop();

HValue* string = Pop();

Drop(1); // Function.

« no previous file with comments | « src/compiler/js-builtin-reducer.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »