Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2905623002: Extract type inference queries from KernelAstAdapter to KernelToTypeInferenceMap (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract type inference queries from KernelAstAdapter to KernelToTypeInferenceMap R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f7cefd76762a669ef6c045f5f46503d817efd7b1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -231 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 2 chunks +50 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 1 chunk +202 lines, -0 lines 2 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 4 chunks +0 lines, -105 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 29 chunks +41 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 5 chunks +96 lines, -90 lines 0 comments Download
M pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-24 11:06:08 UTC) #2
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/2905623002/diff/1/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart File pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart (right): https://codereview.chromium.org/2905623002/diff/1/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart#newcode142 pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart:142: return _closedWorld.commonMasks.dynamicType; \o/ We should rename `dynamic` to ...
3 years, 7 months ago (2017-05-24 17:18:28 UTC) #3
Johnni Winther
https://codereview.chromium.org/2905623002/diff/1/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart File pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart (right): https://codereview.chromium.org/2905623002/diff/1/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart#newcode142 pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart:142: return _closedWorld.commonMasks.dynamicType; On 2017/05/24 17:18:28, Siggi Cherem (dart-lang) wrote: ...
3 years, 6 months ago (2017-05-29 07:50:53 UTC) #4
Johnni Winther
3 years, 6 months ago (2017-05-29 07:59:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f7cefd76762a669ef6c045f5f46503d817efd7b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698