Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4605)

Unified Diff: chrome/browser/resources/md_bookmarks/list.js

Issue 2905553002: Roll closure compiler (Closed)
Patch Set: feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/md_bookmarks/types.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_bookmarks/list.js
diff --git a/chrome/browser/resources/md_bookmarks/list.js b/chrome/browser/resources/md_bookmarks/list.js
index 07951140491ba312e760b37f12ed3423dcf921ae..30b0dcee65aa864c45da92c35fd95730fbae30c4 100644
--- a/chrome/browser/resources/md_bookmarks/list.js
+++ b/chrome/browser/resources/md_bookmarks/list.js
@@ -70,7 +70,9 @@ Polymer({
return {id: id};
});
} else {
- var splices = Polymer.ArraySplice.calculateSplices(newValue, oldValue);
+ var splices = Polymer.ArraySplice.calculateSplices(
+ /** @type {!Array<string>}*/ (newValue),
dpapad 2017/05/24 21:22:13 Nit: Space after "}" /** @type {!Array<string>} */
scottchen 2017/05/25 19:31:26 There's issues with patching a CL with a jar invol
dpapad 2017/05/25 20:34:40 OK.
+ /** @type {!Array<string>}*/ (oldValue));
splices.forEach(function(splice) {
// TODO(calamity): Could use notifySplices to improve performance here.
var additions =
« no previous file with comments | « no previous file | chrome/browser/resources/md_bookmarks/types.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698