Roll closure compiler

chrome/browser/resources/md_bookmarks/list.js

Index: chrome/browser/resources/md_bookmarks/list.js
diff --git a/chrome/browser/resources/md_bookmarks/list.js b/chrome/browser/resources/md_bookmarks/list.js
index 07951140491ba312e760b37f12ed3423dcf921ae..a2d37be510b224bfe02dd848dd1ff4e4238bde32 100644
--- a/chrome/browser/resources/md_bookmarks/list.js
+++ b/chrome/browser/resources/md_bookmarks/list.js
@@ -61,8 +61,8 @@ Polymer({
    * Updates `displayedList_` using splices to be equivalent to `newValue`. This
    * allows the iron-list to delete sublists of items which preserves scroll and
    * focus on incremental update.
-   * @param {Array<string>} newValue
-   * @param {Array<string>} oldValue
+   * @param {!Array<string>} newValue
+   * @param {!Array<string>} oldValue
    */
   onDisplayedIdsChanged_: function(newValue, oldValue) {
     if (!oldValue) {

[Dan Beam, 2017/05/24 02:52:42]

hmmmm, how can !oldValue ever succeed if oldValue is !Array<string>?

[dpapad, 2017/05/24 17:45:42]

The problem is that calculateSplices() has two different type annotations (and
they don't agree)

1) In the externs, it expects non-null
inputshttps://github.com/google/closure-compiler/blob/e1417207f4b28005afdfda0a3f2b217f31615029/contrib/externs/polymer-1.0.js#L1501,L1503
2) In the actual Polymer code, it allows null
https://github.com/Polymer/polymer/blob/fe779eaf791647659ac9564e936336102ea3c...

We only care about 1, which based on previous conversation (on internal JSComp
CL), it seems to be more accurate. So the right solution here (I think) is to
cast to the right types at line 73, instead of modifying the type annotations of
onDisplayedIdsChanged_ parameters.

[scottchen, 2017/05/24 20:36:25]

Done.

[scottchen, 2017/05/24 20:36:25]

Acknowledged.