Roll closure compiler

Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/ee44867683988d37c9cdb1b5c9557fe984c87135...73582c4967874f3fa7e54d60b54c8cbeed985560
chrome_extensions.js: f9877b62e50844da51a50374dbc3c98d31d85ce3 -> 927e44d6e32d7b2f50ddb2b20f6515b79a0914b3
polymer-1.0.js: 5b180dcd7e8913c66386a675086b99aaad2f0a53 -> fa9985deea3ca5077ee47380194f41d06af398c3

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[scottchen, 2017-05-24 01:03:54]

Description was changed from

==========
Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/ee44867683988d37c9cdb1b5c9...
chrome_extensions.js: f9877b62e50844da51a50374dbc3c98d31d85ce3 ->
927e44d6e32d7b2f50ddb2b20f6515b79a0914b3
polymer-1.0.js: 5b180dcd7e8913c66386a675086b99aaad2f0a53 ->
fa9985deea3ca5077ee47380194f41d06af398c3

TBR=
BUG=
==========

to

==========
Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/ee44867683988d37c9cdb1b5c9...
chrome_extensions.js: f9877b62e50844da51a50374dbc3c98d31d85ce3 ->
927e44d6e32d7b2f50ddb2b20f6515b79a0914b3
polymer-1.0.js: 5b180dcd7e8913c66386a675086b99aaad2f0a53 ->
fa9985deea3ca5077ee47380194f41d06af398c3

TBR=
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-05-24 01:06:15]

Description was changed from

==========
Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/ee44867683988d37c9cdb1b5c9...
chrome_extensions.js: f9877b62e50844da51a50374dbc3c98d31d85ce3 ->
927e44d6e32d7b2f50ddb2b20f6515b79a0914b3
polymer-1.0.js: 5b180dcd7e8913c66386a675086b99aaad2f0a53 ->
fa9985deea3ca5077ee47380194f41d06af398c3

TBR=
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/ee44867683988d37c9cdb1b5c9...
chrome_extensions.js: f9877b62e50844da51a50374dbc3c98d31d85ce3 ->
927e44d6e32d7b2f50ddb2b20f6515b79a0914b3
polymer-1.0.js: 5b180dcd7e8913c66386a675086b99aaad2f0a53 ->
fa9985deea3ca5077ee47380194f41d06af398c3

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-05-24 01:06:15]

scottchen@chromium.org changed reviewers:
+ dbeam@chromium.org, dpapad@chromium.org

[Dan Beam, 2017-05-24 02:52:42]

https://codereview.chromium.org/2905553002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/list.js (right):

https://codereview.chromium.org/2905553002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/list.js:68: if (!oldValue) {
hmmmm, how can !oldValue ever succeed if oldValue is !Array<string>?

[dpapad, 2017-05-24 17:45:43]

https://codereview.chromium.org/2905553002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/list.js (right):

https://codereview.chromium.org/2905553002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/list.js:68: if (!oldValue) {
On 2017/05/24 at 02:52:42, Dan Beam wrote:
> hmmmm, how can !oldValue ever succeed if oldValue is !Array<string>?

The problem is that calculateSplices() has two different type annotations (and
they don't agree)

1) In the externs, it expects non-null
inputshttps://github.com/google/closure-compiler/blob/e1417207f4b28005afdfda0a3f2b217f31615029/contrib/externs/polymer-1.0.js#L1501,L1503
2) In the actual Polymer code, it allows null
https://github.com/Polymer/polymer/blob/fe779eaf791647659ac9564e936336102ea3c...

We only care about 1, which based on previous conversation (on internal JSComp
CL), it seems to be more accurate. So the right solution here (I think) is to
cast to the right types at line 73, instead of modifying the type annotations of
onDisplayedIdsChanged_ parameters.

[scottchen, 2017-05-24 20:36:06]

Patchset #3 (id:40001) has been deleted

[scottchen, 2017-05-24 20:36:25]

https://codereview.chromium.org/2905553002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/list.js (right):

https://codereview.chromium.org/2905553002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/list.js:68: if (!oldValue) {
On 2017/05/24 02:52:42, Dan Beam wrote:
> hmmmm, how can !oldValue ever succeed if oldValue is !Array<string>?

Acknowledged.

https://codereview.chromium.org/2905553002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/list.js:68: if (!oldValue) {
On 2017/05/24 17:45:42, dpapad wrote:
> On 2017/05/24 at 02:52:42, Dan Beam wrote:
> > hmmmm, how can !oldValue ever succeed if oldValue is !Array<string>?
> 
> The problem is that calculateSplices() has two different type annotations (and
> they don't agree)
> 
> 1) In the externs, it expects non-null
>
inputshttps://github.com/google/closure-compiler/blob/e1417207f4b28005afdfda0a3f2b217f31615029/contrib/externs/polymer-1.0.js#L1501,L1503
> 2) In the actual Polymer code, it allows null
>
https://github.com/Polymer/polymer/blob/fe779eaf791647659ac9564e936336102ea3c...
> 
> We only care about 1, which based on previous conversation (on internal JSComp
> CL), it seems to be more accurate. So the right solution here (I think) is to
> cast to the right types at line 73, instead of modifying the type annotations
of
> onDisplayedIdsChanged_ parameters.

Done.

[dpapad, 2017-05-24 21:22:13]

LGTM

https://codereview.chromium.org/2905553002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/list.js (right):

https://codereview.chromium.org/2905553002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/list.js:74: /** @type {!Array<string>}*/
(newValue),
Nit: Space after "}"
/** @type {!Array<string>} */

[scottchen, 2017-05-25 19:31:05]

On 2017/05/24 21:22:13, dpapad wrote:
> LGTM
> 
>
https://codereview.chromium.org/2905553002/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/md_bookmarks/list.js (right):
> 
>
https://codereview.chromium.org/2905553002/diff/20001/chrome/browser/resource...
> chrome/browser/resources/md_bookmarks/list.js:74: /** @type {!Array<string>}*/
> (newValue),
> Nit: Space after "}"
> /** @type {!Array<string>} */

There's issues with patching a CL with a jar involved, but I don't have access
to the workstation that uploaded this CL for 2 days, but this is blocking 2
other things, so I will land this now and address the nit in a separate CL.

[scottchen, 2017-05-25 19:31:27]

https://codereview.chromium.org/2905553002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/list.js (right):

https://codereview.chromium.org/2905553002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/list.js:74: /** @type {!Array<string>}*/
(newValue),
On 2017/05/24 21:22:13, dpapad wrote:
> Nit: Space after "}"
> /** @type {!Array<string>} */


There's issues with patching a CL with a jar involved, but I don't have access
to the workstation that uploaded this CL for 2 days, but this is blocking 2
other things, so I will land this now and address the nit in a separate CL.

[dpapad, 2017-05-25 20:34:40]

https://codereview.chromium.org/2905553002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/list.js (right):

https://codereview.chromium.org/2905553002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/list.js:74: /** @type {!Array<string>}*/
(newValue),
> There's issues with patching a CL with a jar involved, but I don't have access
> to the workstation that uploaded this CL for 2 days, but this is blocking 2
> other things, so I will land this now and address the nit in a separate CL.

OK.

[scottchen, 2017-05-30 20:09:26]

On 2017/05/25 20:34:40, dpapad wrote:
>
https://codereview.chromium.org/2905553002/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/md_bookmarks/list.js (right):
> 
>
https://codereview.chromium.org/2905553002/diff/20001/chrome/browser/resource...
> chrome/browser/resources/md_bookmarks/list.js:74: /** @type {!Array<string>}*/
> (newValue),
> > There's issues with patching a CL with a jar involved, but I don't have
access
> > to the workstation that uploaded this CL for 2 days, but this is blocking 2
> > other things, so I will land this now and address the nit in a separate CL.
> 
> OK.

For future reference, I'm not a committer so I'm actually not able to land this
CL, because this CL requires direct landing without CQ (because of the .jar) and
I do not have the permission to do that. Closing, and dpapad will replicate and
land these changes.