cc : Store surface layer ids on LayerTreeHost and push them at commit

cc/layers/surface_layer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/surface_layer.h"
 
 #include <stdint.h>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
@@ skipping 45 matching lines @@
   return make_scoped_refptr(new SurfaceLayer(std::move(ref_factory)));
 }
 
 SurfaceLayer::SurfaceLayer(scoped_refptr<SurfaceReferenceFactory> ref_factory)
     : ref_factory_(std::move(ref_factory)) {}
 
 SurfaceLayer::~SurfaceLayer() {
   DCHECK(!layer_tree_host());
 }
 
+void SurfaceLayer::AddSurfaceId(const SurfaceInfo& surface_info) {
+  DCHECK(layer_tree_host());
+  if (surface_info.is_valid())
+    layer_tree_host()->AddSurfaceLayerId(surface_info.id());
+}
+
+void SurfaceLayer::RemoveSurfaceId(const SurfaceInfo& surface_info) {
+  DCHECK(layer_tree_host());
+  if (surface_info.is_valid())
+    layer_tree_host()->RemoveSurfaceLayerId(surface_info.id());
+}
+
 void SurfaceLayer::SetPrimarySurfaceInfo(const SurfaceInfo& surface_info) {
   RemoveReference(std::move(primary_reference_returner_));
+  if (layer_tree_host())
+    RemoveSurfaceId(primary_surface_info_);
   primary_surface_info_ = surface_info;
   if (layer_tree_host()) {
     primary_reference_returner_ = ref_factory_->CreateReference(
         layer_tree_host(), primary_surface_info_.id());
+    AddSurfaceId(primary_surface_info_);
   }
   UpdateDrawsContent(HasDrawableContent());
   SetNeedsCommit();
 }
 
 void SurfaceLayer::SetFallbackSurfaceInfo(const SurfaceInfo& surface_info) {
   RemoveReference(std::move(fallback_reference_returner_));
+  if (layer_tree_host())
+    RemoveSurfaceId(fallback_surface_info_);
   fallback_surface_info_ = surface_info;
   if (layer_tree_host()) {
     fallback_reference_returner_ = ref_factory_->CreateReference(
         layer_tree_host(), fallback_surface_info_.id());
+    AddSurfaceId(fallback_surface_info_);
   }
   SetNeedsCommit();
 }
 
 void SurfaceLayer::SetStretchContentToFillBounds(
     bool stretch_content_to_fill_bounds) {
   stretch_content_to_fill_bounds_ = stretch_content_to_fill_bounds;
   SetNeedsPushProperties();
 }
 
 std::unique_ptr<LayerImpl> SurfaceLayer::CreateLayerImpl(
     LayerTreeImpl* tree_impl) {
   return SurfaceLayerImpl::Create(tree_impl, id());
 }
 
 bool SurfaceLayer::HasDrawableContent() const {
   return primary_surface_info_.is_valid() && Layer::HasDrawableContent();
 }
 
 void SurfaceLayer::SetLayerTreeHost(LayerTreeHost* host) {
   if (layer_tree_host() == host) {
     Layer::SetLayerTreeHost(host);
     return;
   }
+
+  if (layer_tree_host()) {
+    RemoveSurfaceId(primary_surface_info_);
+    RemoveSurfaceId(fallback_surface_info_);

[Fady Samuel, 2017/05/24 22:31:14]

This breaks surface synchronization and surface references because
|referenced_surfaces| and |activation_dependencies| are expected to be
disjointed sets. |activation_dependencies| don't necessarily yet exist.

[jaydasika, 2017/05/24 22:43:03]

I did not understand how removing surface ids from the old LayerTreeHost breaks
that. Can you elaborate ?

+  }
   RemoveReference(std::move(primary_reference_returner_));
   RemoveReference(std::move(fallback_reference_returner_));
   Layer::SetLayerTreeHost(host);
   if (layer_tree_host()) {
     if (primary_surface_info_.is_valid()) {
       primary_reference_returner_ = ref_factory_->CreateReference(
           layer_tree_host(), primary_surface_info_.id());
     }
     if (fallback_surface_info_.is_valid()) {
       fallback_reference_returner_ = ref_factory_->CreateReference(
           layer_tree_host(), fallback_surface_info_.id());
     }
+    AddSurfaceId(primary_surface_info_);
+    AddSurfaceId(fallback_surface_info_);
   }
 }
 
 void SurfaceLayer::PushPropertiesTo(LayerImpl* layer) {
   Layer::PushPropertiesTo(layer);
   TRACE_EVENT0("cc", "SurfaceLayer::PushPropertiesTo");
   SurfaceLayerImpl* layer_impl = static_cast<SurfaceLayerImpl*>(layer);
   layer_impl->SetPrimarySurfaceInfo(primary_surface_info_);
   layer_impl->SetFallbackSurfaceInfo(fallback_surface_info_);
   layer_impl->SetStretchContentToFillBounds(stretch_content_to_fill_bounds_);
 }
 
 void SurfaceLayer::RemoveReference(base::Closure reference_returner) {
   if (!reference_returner)
     return;
   auto swap_promise = base::MakeUnique<SatisfySwapPromise>(
       std::move(reference_returner),
       layer_tree_host()->GetTaskRunnerProvider()->MainThreadTaskRunner());
   layer_tree_host()->GetSwapPromiseManager()->QueueSwapPromise(
       std::move(swap_promise));
 }
 
 }  // namespace cc