app_shell: Repack extensions strings.

app_shell: Repack extensions strings.

BUG=373540
TEST=see bug for repro; should not DCHECK.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270876

[James Cook, 2014-05-15 21:55:04]

LGTM

[Yoyo Zhou, 2014-05-15 21:57:58]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-05-15 21:58:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoz@chromium.org/290553003/1

[tfarina, 2014-05-15 21:59:13]

https://codereview.chromium.org/290553003/diff/1/apps/shell/app_shell.gyp
File apps/shell/app_shell.gyp (right):

https://codereview.chromium.org/290553003/diff/1/apps/shell/app_shell.gyp#new...
apps/shell/app_shell.gyp:54:
'<(SHARED_INTERMEDIATE_DIR)/extensions/strings/extensions_strings_en-US.pak',
I think you want to depend on extensions_strings target. Don't you?

[Yoyo Zhou, 2014-05-15 22:06:57]

The CQ bit was unchecked by yoz@chromium.org

[Yoyo Zhou, 2014-05-15 22:07:20]

https://codereview.chromium.org/290553003/diff/1/apps/shell/app_shell.gyp
File apps/shell/app_shell.gyp (right):

https://codereview.chromium.org/290553003/diff/1/apps/shell/app_shell.gyp#new...
apps/shell/app_shell.gyp:54:
'<(SHARED_INTERMEDIATE_DIR)/extensions/strings/extensions_strings_en-US.pak',
On 2014/05/15 21:59:13, tfarina wrote:
> I think you want to depend on extensions_strings target. Don't you?

Yes, good catch.

[Yoyo Zhou, 2014-05-15 22:15:55]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-05-15 22:17:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoz@chromium.org/290553003/20001

[commit-bot: I haz the power, 2014-05-16 00:41:26]

Change committed as 270876