Refactor menu dependency on aura/wm SetShadowType

ui/views/widget/widget.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_WIDGET_WIDGET_H_
 #define UI_VIEWS_WIDGET_WIDGET_H_
 
 #include <set>
 #include <stack>
 #include <vector>
@@ skipping 182 matching lines @@
     // fully opaque.  Defaults to TRANSLUCENT_WINDOW if
     // ViewsDelegate::UseTransparentWindows().  Defaults to OPAQUE_WINDOW for
     // non-window widgets.
     WindowOpacity opacity;
     bool accept_events;
     Activatable activatable;
     bool keep_on_top;
     bool visible_on_all_workspaces;
     Ownership ownership;
     bool mirror_origin_in_rtl;
     bool has_dropshadow;

[sky, 2014/05/15 22:37:19]

I believe menus are the only one using this, and it overlaps with what you're
trying to do. Can you extend this to cover what you care about?

[Andre, 2014/05/15 22:49:37]

It is true that menus are the only one using this.
I was extending this at one point, but Trent had a concern that they are
different kinds of shadows.
See
https://codereview.chromium.org/267593005/diff/20001/ui/views/widget/native_w...

Also, the SetShadowType invocation in dialog_delegate.cc is not as part of
Widget::Init, so we won't be able to set up has_dropshadow there.

[sky, 2014/05/15 22:55:10]

They are all shadows though. Create an enum if you need to.
Can the places that create a dialog set it in the initparams?

     // Specifies that the system default caption and icon should not be
     // rendered, and that the client area should be equivalent to the window
     // area. Only used on some platforms (Windows and Linux).
     bool remove_standard_frame;
     // Only used by ShellWindow on Windows. Specifies that the default icon of
     // packaged app should be the system default icon.
     bool use_system_default_icon;
     // Whether the widget should be maximized or minimized.
     ui::WindowShowState show_state;
     // Should the widget be double buffered? Default is false.
@@ skipping 284 matching lines @@
 
   // Accessors for fullscreen state.
   void SetFullscreen(bool fullscreen);
   bool IsFullscreen() const;
 
   // Sets the opacity of the widget. This may allow widgets behind the widget
   // in the Z-order to become visible, depending on the capabilities of the
   // underlying windowing system.
   void SetOpacity(unsigned char opacity);
 
+  // Informs the window manager whether to create a rectangular shadow around
+  // the window, and keep it updated in response to activation changes.
+  void SetHasActivationShadow(bool has_shadow);
+
   // Sets whether or not the window should show its frame as a "transient drag
   // frame" - slightly transparent and without the standard window controls.
   void SetUseDragFrame(bool use_drag_frame);
 
   // Flashes the frame of the window to draw attention to it. Currently only
   // implemented on Windows for non-Aura.
   void FlashFrame(bool flash);
 
   // Returns the View at the root of the View hierarchy contained by this
   // Widget.
@@ skipping 412 matching lines @@
   bool movement_disabled_;
 
   ScopedObserver<ui::NativeTheme, ui::NativeThemeObserver> observer_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(Widget);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_WIDGET_WIDGET_H_