Making answer card to behave like other results.

ui/app_list/views/contents_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/contents_view.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/logging.h"
 #include "ui/app_list/app_list_constants.h"
 #include "ui/app_list/app_list_switches.h"
 #include "ui/app_list/app_list_view_delegate.h"
 #include "ui/app_list/views/app_list_folder_view.h"
 #include "ui/app_list/views/app_list_main_view.h"
 #include "ui/app_list/views/apps_container_view.h"
 #include "ui/app_list/views/apps_grid_view.h"
 #include "ui/app_list/views/custom_launcher_page_view.h"
 #include "ui/app_list/views/search_box_view.h"
+#include "ui/app_list/views/search_result_answer_card_view.h"
 #include "ui/app_list/views/search_result_list_view.h"
 #include "ui/app_list/views/search_result_page_view.h"
 #include "ui/app_list/views/search_result_tile_item_list_view.h"
 #include "ui/app_list/views/start_page_view.h"
 #include "ui/events/event.h"
 #include "ui/resources/grit/ui_resources.h"
-#include "ui/views/layout/box_layout.h"
 #include "ui/views/view_model.h"
 #include "ui/views/widget/widget.h"
 
 namespace app_list {
 
-namespace {
-
-// Container of the search answer view.
-class SearchAnswerContainerView : public views::View {
- public:
-  explicit SearchAnswerContainerView(views::View* search_results_page_view)
-      : search_results_page_view_(search_results_page_view) {
-    views::BoxLayout* answer_container_layout =
-        new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0, 0);
-    answer_container_layout->set_main_axis_alignment(
-        views::BoxLayout::MAIN_AXIS_ALIGNMENT_CENTER);
-    SetLayoutManager(answer_container_layout);
-  }
-
-  // views::View overrides:
-  void ChildPreferredSizeChanged(View* child) override {
-    if (visible())
-      search_results_page_view_->Layout();
-  }
-
-  const char* GetClassName() const override {
-    return "SearchAnswerContainerView";
-  }
-
- private:
-  views::View* const search_results_page_view_;
-
-  DISALLOW_COPY_AND_ASSIGN(SearchAnswerContainerView);
-};
-
-}  // namespace
-
 ContentsView::ContentsView(AppListMainView* app_list_main_view)
     : model_(nullptr),
       apps_container_view_(nullptr),
       search_results_page_view_(nullptr),
       start_page_view_(nullptr),
       custom_page_view_(nullptr),
-      search_answer_container_view_(nullptr),
       app_list_main_view_(app_list_main_view),
       page_before_search_(0) {
   pagination_model_.SetTransitionDurations(kPageTransitionDurationInMs,
                                            kOverscrollPageTransitionDurationMs);
   pagination_model_.AddObserver(this);
 }
 
 ContentsView::~ContentsView() {
   pagination_model_.RemoveObserver(this);
-  if (model_)
-    model_->RemoveObserver(this);
 }
 
 void ContentsView::Init(AppListModel* model) {
   DCHECK(model);
   model_ = model;
 
   AppListViewDelegate* view_delegate = app_list_main_view_->view_delegate();
 
   std::vector<views::View*> custom_page_views =
       view_delegate->CreateCustomPageWebViews(GetLocalBounds().size());
   // Only add the first custom page view as STATE_CUSTOM_LAUNCHER_PAGE. Ignore
   // any subsequent custom pages.
   if (!custom_page_views.empty()) {
     custom_page_view_ = new CustomLauncherPageView(custom_page_views[0]);
 
     AddLauncherPage(custom_page_view_,
                     AppListModel::STATE_CUSTOM_LAUNCHER_PAGE);
   }
 
   // Start page.
   start_page_view_ = new StartPageView(app_list_main_view_, view_delegate);
   AddLauncherPage(start_page_view_, AppListModel::STATE_START);
 
   // Search results UI.
   search_results_page_view_ = new SearchResultPageView();
 
-  // Search answer container UI.
-  search_answer_container_view_ =
-      new SearchAnswerContainerView(search_results_page_view_);
-  search_answer_container_view_->SetVisible(false);
-  views::View* search_answer_view = view_delegate->GetSearchAnswerWebView();
-  if (search_answer_view)
-    search_answer_container_view_->AddChildView(search_answer_view);
-  search_results_page_view_->AddChildView(search_answer_container_view_);
+  // Search result containers.
+  views::View* const search_answer_view =
+      view_delegate->GetSearchAnswerWebView();
+  if (search_answer_view) {
+    search_results_page_view_->AddSearchResultContainerView(
+        nullptr, new SearchResultAnswerCardView(

[xiyuan, 2017/05/25 16:42:53]

nullptr looks strange. Can we following the existing convention that a
SearchResultContainerView gets the model in SetResults ?

[vadimt, 2017/05/25 20:15:16]

This is more readable, as this container doesn't use these results, and gets
updates and data from different sources.

+                     model_, search_results_page_view_, search_answer_view));
+  }
 
   AppListModel::SearchResults* results = view_delegate->GetModel()->results();
   search_results_page_view_->AddSearchResultContainerView(
       results, new SearchResultListView(app_list_main_view_, view_delegate));
 
   search_results_page_view_->AddSearchResultContainerView(
       results, new SearchResultTileItemListView(
                    GetSearchBoxView()->search_box(), view_delegate));
   AddLauncherPage(search_results_page_view_,
                   AppListModel::STATE_SEARCH_RESULTS);
@@ skipping 10 matching lines @@
   // (as it will trigger a SelectedPageChanged call).
   pagination_model_.SetTotalPages(app_list_pages_.size());
 
   // Page 0 is selected by SetTotalPages and needs to be 'hidden' when selecting
   // the initial page.
   app_list_pages_[GetActivePageIndex()]->OnWillBeHidden();
 
   pagination_model_.SelectPage(initial_page_index, false);
 
   ActivePageChanged();
-
-  model_->AddObserver(this);
 }
 
 void ContentsView::CancelDrag() {
   if (apps_container_view_->apps_grid_view()->has_dragged_view())
     apps_container_view_->apps_grid_view()->EndDrag(true);
   if (apps_container_view_->app_list_folder_view()
           ->items_grid_view()
           ->has_dragged_view()) {
     apps_container_view_->app_list_folder_view()->items_grid_view()->EndDrag(
         true);
@@ skipping 360 matching lines @@
     app_list_pages_[new_selected]->OnShown();
 }
 
 void ContentsView::TransitionStarted() {
 }
 
 void ContentsView::TransitionChanged() {
   UpdatePageBounds();
 }
 
-void ContentsView::OnSearchAnswerAvailableChanged(bool has_answer) {
-  if (has_answer == search_answer_container_view_->visible())
-    return;
-
-  search_answer_container_view_->SetVisible(has_answer);
-  search_results_page_view_->Layout();
-}
-
 }  // namespace app_list