plumb network upload into the task manager

chrome/browser/task_manager/task_manager_interface.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_INTERFACE_H_
 #define CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_INTERFACE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 33 matching lines @@
   static void RegisterPrefs(PrefRegistrySimple* registry);
 
   // Returns true if the user is allowed to end processes.
   static bool IsEndProcessEnabled();
 
   // Gets the existing instance of the task manager if any, otherwise it will
   // create it first. Must be called on the UI thread.
   static TaskManagerInterface* GetTaskManager();
 
   // This notification will be received on the IO thread from
-  // ChromeNetworkDelegate to update the task manager with network usage.
+  // ChromeNetworkDelegate to update the task manager with read network usage.
   static void OnRawBytesRead(const net::URLRequest& request,
                              int64_t bytes_read);
 
+  // This notification will be received on the IO thread from
+  // ChromeNetworkDelegate to update the task manager with sent network usage.
+  static void OnRawBytesSent(const net::URLRequest& request,
+                             int64_t bytes_sent);
+
   void AddObserver(TaskManagerObserver* observer);
   void RemoveObserver(TaskManagerObserver* observer);
 
   // Activates the task with |task_id| by bringing its container to the front if
   // possible.
   virtual void ActivateTask(TaskId task_id) = 0;
 
   // Returns if the task is killable.
   virtual bool IsTaskKillable(TaskId task_id) = 0;
 
@@ skipping 97 matching lines @@
 
   // If the process, in which the task with |task_id| is running, is terminated
   // this gets the termination status. Currently implemented only for Renderer
   // processes. The values will only be valid if the process has actually
   // terminated.
   virtual void GetTerminationStatus(TaskId task_id,
                                     base::TerminationStatus* out_status,
                                     int* out_error_code) const = 0;
 
   // Returns the network usage (in bytes per second) during the current refresh
-  // cycle for the task with |task_id|. A value of -1 means no valid value is
-  // currently available or that task has never been notified of any network
-  // usage.
+  // cycle for the task with |task_id|.
   virtual int64_t GetNetworkUsage(TaskId task_id) const = 0;
 
+  // Returns the network usage during the current lifetime of the task
+  // for the task with |task_id|.
+  virtual int64_t GetCumulativeNetworkUsage(TaskId task_id) const = 0;
+
   // Returns the total network usage (in bytes per second) during the current
   // refresh cycle for the process on which the task with |task_id| is running.
   // This is the sum of all the network usage of the individual tasks (that
   // can be gotten by the above GetNetworkUsage()). A value of -1 means network
   // usage calculation refresh is currently not available.
   virtual int64_t GetProcessTotalNetworkUsage(TaskId task_id) const = 0;
 
+  // Returns the total network usage during the lifetime of the process
+  // on which the task with |task_id| is running.
+  // This is the sum of all the network usage of the individual tasks (that
+  // can be gotten by the above GetTotalNetworkUsage()). A value of -1
+  // means network usage calculation refresh is currently not available.

[ncarter (slow), 2017/06/20 19:52:27]

GetCumulativeProcessTotalNetworkUsage doesn't seem to ever return -1.

(GetProcessTotalNetworkUsage does return -1, however)

[cburn, 2017/06/20 21:34:56]

Done.

+  virtual int64_t GetCumulativeProcessTotalNetworkUsage(
+      TaskId task_id) const = 0;
+
   // Returns the Sqlite used memory (in bytes) for the task with |task_id|.
   // A value of -1 means no valid value is currently available.
   virtual int64_t GetSqliteMemoryUsed(TaskId task_id) const = 0;
 
   // Returns the allocated and used V8 memory (in bytes) for the task with
   // |task_id|. A return value of false means no valid value is currently
   // available.
   virtual bool GetV8Memory(TaskId task_id,
                            int64_t* allocated,
                            int64_t* used) const = 0;
@@ skipping 89 matching lines @@
 
   // The flags containing the enabled resources types calculations.
   int64_t enabled_resources_flags_;
 
   DISALLOW_COPY_AND_ASSIGN(TaskManagerInterface);
 };
 
 }  // namespace task_manager
 
 #endif  // CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_INTERFACE_H_