plumb network upload into the task manager

chrome/browser/task_manager/task_manager_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <vector>
 
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "base/path_service.h"
@@ skipping 654 matching lines @@
   // Wait for the heap stats to reflect this.
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerStatToExceed(
       MatchTab("title1.html"), ColumnSpecifier::V8_MEMORY, minimal_heap_size));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerStatToExceed(
       MatchTab("title1.html"), ColumnSpecifier::V8_MEMORY_USED,
       minimal_heap_size));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchTab("title1.html")));
 }
 
+IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, SentDataObserved) {
+  ShowTaskManager();
+  GURL test_gurl = embedded_test_server()->GetURL("/title1.html");
+
+  ui_test_utils::NavigateToURL(browser(), test_gurl);
+  std::string test_js = R"(
+      document.title = 'network use';
+      var mem = new Uint8Array(16 << 20);
+      for (var i = 0; i < mem.length; i += 16) {
+        mem[i] = i;
+      }
+      var formData = new FormData();
+      formData.append('StringKey1', new Blob([mem]));
+      var request =
+          new Request(location.href, {method: 'POST', body: formData});
+      fetch(request).then(response => response.text());
+      )";
+
+  browser()
+      ->tab_strip_model()
+      ->GetActiveWebContents()
+      ->GetMainFrame()
+      ->ExecuteJavaScriptForTests(base::UTF8ToUTF16(test_js));

[ncarter (slow), 2017/06/20 19:52:27]

Add in:

// TODO(cburn): The assertion below currently assumes that the rate contribution
of the entire 16MB upload arrives in a single refresh cycle. That's true now
because it's only reported when the transaction completes, but if that changes
in the future, this assertion may need to change.

(btw -- this is totally academic -- if we change it to something, one idea is to
assert that the peak reported network use exceeded (16 << 20) / elapsed_time,
where elapsed_time for the period that we were waiting. by, like, [waves hands
vigorously] the mean value theorem?)

[cburn, 2017/06/20 21:34:55]

Done.

+  ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerStatToExceed(
+      MatchTab("network use"), ColumnSpecifier::NETWORK_USE, 16000000));
+}
+
+IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, TotalSentDataObserved) {
+  ShowTaskManager();
+  GURL test_gurl = embedded_test_server()->GetURL("/title1.html");
+
+  ui_test_utils::NavigateToURL(browser(), test_gurl);
+  std::string test_js = R"(
+      document.title = 'network use';
+      var mem = new Uint8Array(16 << 20);
+      for (var i = 0; i < mem.length; i += 16) {
+        mem[i] = i;
+      }
+      var formData = new FormData();
+      formData.append('StringKey1', new Blob([mem]));
+      var request =
+          new Request(location.href, {method: 'POST', body: formData});
+      fetch(request).then(response => response.text());
+      )";
+
+  browser()
+      ->tab_strip_model()
+      ->GetActiveWebContents()
+      ->GetMainFrame()
+      ->ExecuteJavaScriptForTests(base::UTF8ToUTF16(test_js));
+
+  // This test uses |setTimeout| to exceed the Nyquist ratio to ensure that at
+  // least 1 refresh has happened of no traffic.
+  test_js = R"(
+      var request =
+          new Request(location.href, {method: 'POST', body: formData});
+      setTimeout(
+          () => {fetch(request).then(response => response.text())}, 2000);
+      )";
+
+  browser()
+      ->tab_strip_model()
+      ->GetActiveWebContents()
+      ->GetMainFrame()
+      ->ExecuteJavaScriptForTests(base::UTF8ToUTF16(test_js));
+  ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerStatToExceed(
+      MatchTab("network use"), ColumnSpecifier::TOTAL_NETWORK_USE,
+      16000000 * 2));
+}
+
 // Checks that task manager counts idle wakeups.
 // Flakily fails on Mac: http://crbug.com/639939
 #if defined(OS_MACOSX)
 #define MAYBE_IdleWakeups DISABLED_IdleWakeups
 #else
 #define MAYBE_IdleWakeups IdleWakeups
 #endif  // defined(OS_MACOSX)
 IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest,
                        MAYBE_IdleWakeups) {
   ShowTaskManager();
@@ skipping 483 matching lines @@
 
     // Because the subframes for tab 2 are nested, their order is deterministic.
     EXPECT_EQ("Subframe: http://a.com/",
               base::UTF16ToUTF8(model()->GetRowTitle(tab2_start + 1)));
     EXPECT_EQ("Subframe: http://c.com/",
               base::UTF16ToUTF8(model()->GetRowTitle(tab2_start + 2)));
     EXPECT_EQ("Subframe: http://b.com/",
               base::UTF16ToUTF8(model()->GetRowTitle(tab2_start + 3)));
   }
 }