plumb network upload into the task manager

chrome/browser/task_manager/sampling/task_manager_io_thread_helper.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_manager/sampling/task_manager_io_thread_helper.h"
 
 #include "chrome/browser/task_manager/sampling/task_manager_impl.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/resource_request_info.h"
 
@@ skipping 41 matching lines @@
 
   delete g_io_thread_helper;
   g_io_thread_helper = nullptr;
 }
 
 // static
 void TaskManagerIoThreadHelper::OnRawBytesRead(const net::URLRequest& request,
                                                int64_t bytes_read) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
 
-  if (g_io_thread_helper)
-    g_io_thread_helper->OnNetworkBytesRead(request, bytes_read);
+  if (g_io_thread_helper) {
+    int64_t bytes_sent = 0;
+    g_io_thread_helper->OnNetworkBytesTransfered(request, bytes_read,
+                                                 bytes_sent);

[ncarter (slow), 2017/06/17 00:21:01]

You can also consider using this style:

OnNetworkBytesTransfered(request, bytes_read, 0 /* bytes_sent */)

[cburn, 2017/06/19 22:07:08]

Acknowledged.

+  }
+}
+
+// static
+void TaskManagerIoThreadHelper::OnRawBytesSent(const net::URLRequest& request,
+                                               int64_t bytes_sent) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+  if (g_io_thread_helper) {
+    int64_t bytes_read = 0;
+    g_io_thread_helper->OnNetworkBytesTransfered(request, bytes_read,
+                                                 bytes_sent);
+  }
 }
 
 TaskManagerIoThreadHelper::TaskManagerIoThreadHelper() : weak_factory_(this) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
 }
 
 TaskManagerIoThreadHelper::~TaskManagerIoThreadHelper() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
 }
 
-void TaskManagerIoThreadHelper::OnMultipleBytesReadIO() {
+void TaskManagerIoThreadHelper::OnMultipleBytesTransferedIO() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
 
-  DCHECK(!bytes_read_buffer_.empty());
+  DCHECK(!bytes_transfered_buffer_.empty());
 
-  std::vector<BytesReadParam>* bytes_read_buffer =
-      new std::vector<BytesReadParam>();
-  bytes_read_buffer_.swap(*bytes_read_buffer);
+  std::vector<BytesTransferedParam>* bytes_read_buffer =
+      new std::vector<BytesTransferedParam>();
+  bytes_transfered_buffer_.swap(*bytes_read_buffer);
 
   content::BrowserThread::PostTask(
-      content::BrowserThread::UI,
-      FROM_HERE,
-      base::Bind(&TaskManagerImpl::OnMultipleBytesReadUI,
+      content::BrowserThread::UI, FROM_HERE,
+      base::Bind(&TaskManagerImpl::OnMultipleBytesTransferedUI,
                  base::Owned(bytes_read_buffer)));
 }
 
-void TaskManagerIoThreadHelper::OnNetworkBytesRead(
-    const net::URLRequest& request, int64_t bytes_read) {
+void TaskManagerIoThreadHelper::OnNetworkBytesTransfered(
+    const net::URLRequest& request,
+    int64_t bytes_read,
+    int64_t bytes_sent) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
 
   // Only net::URLRequestJob instances created by the ResourceDispatcherHost
   // have an associated ResourceRequestInfo and a render frame associated.
   // All other jobs will have -1 returned for the render process child and
   // routing ids - the jobs may still match a resource based on their origin id,
   // otherwise BytesRead() will attribute the activity to the Browser resource.
   const content::ResourceRequestInfo* info =
       content::ResourceRequestInfo::ForRequest(&request);
   int child_id = -1;
   int route_id = -1;
   if (info)
     info->GetAssociatedRenderFrame(&child_id, &route_id);
 
   // Get the origin PID of the request's originator.  This will only be set for
   // plugins - for renderer or browser initiated requests it will be zero.
   int origin_pid = info ? info->GetOriginPID() : 0;
 
-  if (bytes_read_buffer_.empty()) {
+  if (bytes_transfered_buffer_.empty()) {
     // Schedule a task to process the received bytes requests a second from now.
     // We're trying to calculate the tasks' network usage speed as bytes per
     // second so we collect as many requests during one seconds before the below
     // delayed TaskManagerIoThreadHelper::OnMultipleBytesReadIO() process them
     // after one second from now.
     content::BrowserThread::PostDelayedTask(
         content::BrowserThread::IO, FROM_HERE,
-        base::Bind(&TaskManagerIoThreadHelper::OnMultipleBytesReadIO,
+        base::Bind(&TaskManagerIoThreadHelper::OnMultipleBytesTransferedIO,
                    weak_factory_.GetWeakPtr()),
         base::TimeDelta::FromSeconds(1));
   }
 
-  bytes_read_buffer_.push_back(
-      BytesReadParam(origin_pid, child_id, route_id, bytes_read));
+  bytes_transfered_buffer_.push_back(BytesTransferedParam(
+      origin_pid, child_id, route_id, bytes_read, bytes_sent));
 }
 
 }  // namespace task_manager