plumb network upload into the task manager

chrome/browser/task_manager/providers/task.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_TASK_MANAGER_PROVIDERS_TASK_H_
 #define CHROME_BROWSER_TASK_MANAGER_PROVIDERS_TASK_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 67 matching lines @@
 
   // Will be called to let the task refresh itself between refresh cycles.
   // |update_interval| is the time since the last task manager refresh.
   // the |refresh_flags| indicate which resources should be calculated on each
   // refresh.
   virtual void Refresh(const base::TimeDelta& update_interval,
                        int64_t refresh_flags);
 
   // Will receive this notification through the task manager from
   // |ChromeNetworkDelegate::OnNetworkBytesReceived()|. The task will add to the
-  // |current_byte_count_| in this refresh cycle.
+  // |current_read_byte_count_| in this refresh cycle.
   void OnNetworkBytesRead(int64_t bytes_read);
 
+  // Will receive this notification through the task manager from
+  // |ChromeNetworkDelegate::OnNetworkBytesSent()|. The task will add to the
+  // |current_sent_byte_count_| in this refresh cycle.
+  void OnNetworkBytesSent(int64_t bytes_sent);
+
   // Returns the task type.
   virtual Type GetType() const = 0;
 
   // This is the unique ID of the BrowserChildProcessHost/RenderProcessHost. It
   // is not the PID nor the handle of the process.
   // For a task that represents the browser process, the return value is 0. For
   // other tasks that represent renderers and other child processes, the return
   // value is whatever unique IDs of their hosts in the browser process.
   virtual int GetChildProcessUniqueID() const = 0;
 
@@ skipping 35 matching lines @@
   virtual blink::WebCache::ResourceTypeStats GetWebCacheStats() const;
 
   // Returns the keep-alive counter if the Task is an event page, -1 otherwise.
   virtual int GetKeepaliveCount() const;
 
   // Checking whether the task reports network usage.
   bool ReportsNetworkUsage() const;
 
   int64_t task_id() const { return task_id_; }
   int64_t network_usage() const { return network_usage_; }
+  int64_t total_network_usage() const { return total_network_usage_; }
   const base::string16& title() const { return title_; }
   const std::string& rappor_sample_name() const { return rappor_sample_name_; }
   const gfx::ImageSkia& icon() const { return icon_; }
   const base::ProcessHandle& process_handle() const { return process_handle_; }
   const base::ProcessId& process_id() const { return process_id_; }
 
  protected:
   void set_title(const base::string16& new_title) { title_ = new_title; }
   void set_rappor_sample_name(const std::string& sample) {
     rappor_sample_name_ = sample;
   }
   void set_icon(const gfx::ImageSkia& new_icon) { icon_ = new_icon; }
 
  private:
   // The unique ID of this task.
   const int64_t task_id_;
 
   // The task's network usage in the current refresh cycle measured in bytes per
   // second. A value of -1 means this task doesn't report network usage data.
   int64_t network_usage_;
 
+  // The task's  total network usage for its lifetime measured in bytes

[ncarter (slow), 2017/06/08 23:37:18]

Extra space before 'total'

[cburn, 2017/06/14 18:04:37]

Done.

+  // A value of -1 means this task doesn't report network usage data.
+  int64_t total_network_usage_;
+
+  // The task's network usage for reading data in the current refresh cycle
+  // measured in bytes per second. A value of -1 means this task doesn't report
+  // network usage data.
+  int64_t network_read_usage_;
+
+  // The task's network usage for sending data in the current refresh cycle
+  // measured in bytes per second. A value of -1 means this task doesn't report
+  // network usage data.
+  int64_t network_sent_usage_;
+
+  // TODO: cburn clearn this up
+  // The current network bytes sent and received by this task during the current
+  // refresh cycle. A value of -1 means this task has never been notified of any
+  // network usage.
+  // int64_t current_byte_count_;
+
   // The current network bytes received by this task during the current refresh
   // cycle. A value of -1 means this task has never been notified of any network
   // usage.
-  int64_t current_byte_count_;
+  int64_t current_read_byte_count_;
+
+  // The current network bytes sent by this task during the current refresh
+  // cycle. A value of -1 means this task has never been notified of any network
+  // usage.
+  int64_t current_sent_byte_count_;
+
+  // The current total number of bytes read by this task. A value of -1 means
+  // that this task has never read any bytes.
+  int64_t total_read_byte_count_;
+
+  // The current total number of bytes sent by this task. A value of -1 means
+  // that this task has never sent any bytes.
+  int64_t total_sent_byte_count_;

[ncarter (slow), 2017/06/08 23:37:18]

Let's try to reduce the number of fields here to as few as possible -- I think
four should suffice, and we can interpolate the rest:

  last_refresh_cumulative_bytes_sent_
  cumulative_bytes_sent_
  last_refresh_cumulative_bytes_read_
  cumulative_bytes_read_
  (maybe we need to store a TimeDelta too, but that's less clear to me)

the rate can be determined then by (last_refresh_cumulative - cumulative) /
(time interval), and the combined totals can just be computed by adding (sent +
read).

It's fine to expose a getter_function() that does simple arithmetic (e.g. to get
the totals).

[cburn, 2017/06/14 18:04:37]

Done.

 
   // The title of the task.
   base::string16 title_;
 
   // The name of the sample representing this task when a Rappor sample needs to
   // be recorded for it.
   std::string rappor_sample_name_;
 
   // The favicon.
   gfx::ImageSkia icon_;
 
   // The handle of the process on which this task is running.
   const base::ProcessHandle process_handle_;
 
   // The PID of the process on which this task is running.
   const base::ProcessId process_id_;
 
   DISALLOW_COPY_AND_ASSIGN(Task);
 };
 
 }  // namespace task_manager
 
 #endif  // CHROME_BROWSER_TASK_MANAGER_PROVIDERS_TASK_H_