MD Settings: URL encode text queries before adding them to the URL.

chrome/test/data/webui/settings/settings_ui_browsertest.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for the Settings layout. */
 
 GEN_INCLUDE(['settings_page_browsertest.js']);
 
 /**
  * @constructor
@@ skipping 115 matching lines @@
 
       settings.navigateTo(
           settings.Route.BASIC, /* dynamicParams */ null,
           /* removeSearch */ true);
       assertEquals('', searchField.getSearchInput().value);
       assertFalse(settings.getQueryParameters().has('search'));
 
       var value = 'GOOG';
       searchField.setValue(value);
       assertEquals(value, settings.getQueryParameters().get('search'));
+
+      // Test that search queries are properly URL encoded.
+      value = '+++';
+      searchField.setValue(value);

[dschuyler, 2017/05/27 01:32:13]

wdyt of asserting that the internal value of searchField does  not  match the
local |value| var?

[dpapad, 2017/05/27 01:39:34]

That would not be correct (the internal value DOES match |value|). Its' the URL
that does not match (chrome://md-settings/?search=%2B%2B%2B). This is clearer if
you try the following in the dev console.

new URLSearchParams('search=' + '+++').get('search') // returns '   ' which is
wrong
new URLSearchParams('search=' + encodeURIComponent('+++')).get('search') //
returns '+++' which is right

Let me know if that did not answer your question (I am not sure).

[dschuyler, 2017/05/27 01:44:18]

Acknowledged.

+      assertEquals(value, settings.getQueryParameters().get('search'));

[dpapad, 2017/05/27 00:18:10]

I verified that this test would have caught the problem. Unfortunately though,
tests in this file are disabled above (see DISABLED_All). I'll look into
potentially re-enabling them in follow up CL.

     });
 
      test('whitespace only search query is ignored', function() {
       toolbar = /** @type {!CrToolbarElement} */ (ui.$$('cr-toolbar'));
       var searchField = /** @type {CrToolbarSearchFieldElement} */ (
           toolbar.getSearchField());
       searchField.setValue('    ');
       var urlParams = settings.getQueryParameters();
       assertFalse(urlParams.has('search'));
 
       searchField.setValue('   foo');
       urlParams = settings.getQueryParameters();
       assertEquals('foo', urlParams.get('search'));
 
       searchField.setValue('   foo ');
       urlParams = settings.getQueryParameters();
       assertEquals('foo ', urlParams.get('search'));
 
       searchField.setValue('   ');
       urlParams = settings.getQueryParameters();
       assertFalse(urlParams.has('search'));
     });
   });
 
   mocha.run();
 });