Set keys for SwitchAccessEventHandler to capture using accessibiltyPrivate API

chrome/browser/accessibility/accessibility_extension_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/accessibility/accessibility_extension_api.h"
 
 #include <stddef.h>
 
 #include "base/json/json_writer.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
 #include "chrome/browser/extensions/chrome_extension_function_details.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/api/accessibility_private.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "components/infobars/core/infobar.h"
 #include "content/public/browser/browser_accessibility_state.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/lazy_background_task_queue.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/image_util.h"
 #include "extensions/common/manifest_handlers/background_info.h"
+#include "ui/events/keycodes/keyboard_codes.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/accessibility/accessibility_manager.h"
 #include "chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/power_manager_client.h"
 
 using chromeos::AccessibilityFocusRingController;
 #endif
 
@@ skipping 117 matching lines @@
 
   // Called twice to ensure the cros end of the dbus message is in a good
   // state.
   client->SetBacklightsForcedOff(!darken);
   client->SetBacklightsForcedOff(darken);
   return RespondNow(NoArguments());
 #endif  // defined OS_CHROMEOS
 
   return RespondNow(Error(kErrorNotSupported));
 }
+
+#if defined(OS_CHROMEOS)
+ExtensionFunction::ResponseAction
+AccessibilityPrivateSetSwitchAccessKeysFunction::Run() {
+  std::unique_ptr<accessibility_private::SetSwitchAccessKeys::Params> params =
+      accessibility_private::SetSwitchAccessKeys::Params::Create(*args_);
+  EXTENSION_FUNCTION_VALIDATE(params);
+  std::vector<int> key_codes_list = params->key_codes;

[Devlin, 2017/06/02 02:02:36]

No need to copy this; prefer const std::vector<int>& (or just use
params->key_codes; it isn't used frequently and isn't that unreadable).

[elichtenberg, 2017/06/02 17:57:47]

Done.

+
+  // For now, only accept key code if it represents an alphanumeric character.
+  std::set<int> key_codes;
+  for (size_t i = 0; i < key_codes_list.size(); ++i) {

[Devlin, 2017/06/02 02:02:36]

prefer:
for (auto key_code : key_codes_list) {
  EXTENSION_FUNCTION_VALIDATE(...);
  key_codes.insert(key_code);
}

[elichtenberg, 2017/06/02 17:57:46]

Done.

+    int key_code = key_codes_list.at(i);
+    EXTENSION_FUNCTION_VALIDATE(key_code >= ui::VKEY_0 &&
+                                key_code <= ui::VKEY_Z);
+    key_codes.insert(key_code);
+  }
+
+  chromeos::AccessibilityManager* manager =
+      chromeos::AccessibilityManager::Get();
+
+  // AccessibilityManager can be null during system shut down, but no need to
+  // return error in this case, so just check that manager is not null.
+  if (manager)
+    manager->SetSwitchAccessKeys(key_codes);
+  return RespondNow(NoArguments());
+}
+#endif  // defined (OS_CHROMEOS)