Enable multidex for ChromePublicTests app

chrome/android/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/android/rules.gni")
 import("//build/util/process_version.gni")
 import("//chrome/android/chrome_public_apk_tmpl.gni")
 import("//chrome/android/monochrome_android_manifest_jinja_variables.gni")
 import("//chrome/chrome_paks.gni")
@@ skipping 897 matching lines @@
     "//chrome/android/webapk/libs/runtime_library/javatests/apk_with_webapk_service:apk_with_webapk_service",
     "//chrome/android/webapk/shell_apk:webapk_javatests",
     "//chrome/android/webapk/shell_apk/javatests/dex_optimizer:dex_optimizer_apk",
     "//chrome/test/android/chrome_public_test_support:chrome_public_test_support_apk",
     "//net/android:net_test_support_apk",
   ]
   proguard_enabled = !is_java_debug
 
   # The test APK contains code from both the APK under test and the
   # test APK when proguard is enabled. That causes this APK to exceed
-  # the dex limit.
-  enable_multidex = proguard_enabled
+  # the dex limit.  Using android.support.multidex.MultiDexApplication

[jbudorick, 2017/06/06 05:44:59]

This is not the right place for this comment. It'd be fine in the manifest,
though.

[aluo, 2017/06/07 00:52:17]

Done.

+  # to support this case which requires multidex support.  Can't use
+  # BaseChromiumApplication due to BuildConfig.java conflict with
+  # chrome_public_apk.
+  enable_multidex = true

[jbudorick, 2017/06/06 05:44:59]

I don't think this is the right way to ensure MultiDexApplication is included.
Instead, I think you could do this by adding
//third_party/android_tools:android_support_multidex_java to deps above.

[aluo, 2017/06/07 00:52:17]

That wasn't enough, still couldn't find class in debug mode:
android.support.multidex.MultiDexApplication" on path: DexPathList[[zip file
"/system/framework/android.test.runner.jar", zip file
"/data/app/org.chromium.chrome.tests-1.apk"],nativeLibraryDirectories=[/data/app-lib/org.chromium.chrome.tests-1,
/vendor/lib, /system/lib]]
E/AndroidRuntime( 6139): 	at
android.app.LoadedApk.makeApplication(LoadedApk.java:507)
E/AndroidRuntime( 6139): 	at
android.app.ActivityThread.handleBindApplication(ActivityThread.java:4301)
E/AndroidRuntime( 6139): 	at
android.app.ActivityThread.access$1500(ActivityThread.java:135)
E/AndroidRuntime( 6139): 	at
android.app.ActivityThread$H.handleMessage(ActivityThread.java:1256)
E/AndroidRuntime( 6139): 	at
android.os.Handler.dispatchMessage(Handler.java:102)
E/AndroidRuntime( 6139): 	at android.os.Looper.loop(Looper.java:136)
E/AndroidRuntime( 6139): 	at
android.app.ActivityThread.main(ActivityThread.java:5001)
E/AndroidRuntime( 6139): 	at java.lang.reflect.Method.invokeNative(Native
Method)
E/AndroidRuntime( 6139): 	at java.lang.reflect.Method.invoke(Method.java:515)
E/AndroidRuntime( 6139): 	at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
E/AndroidRuntime( 6139): 	at
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
E/AndroidRuntime( 6139): 	at dalvik.system.NativeStart.main(Native Method)
E/AndroidRuntime( 6139): Caused by: java.lang.ClassNotFoundException: Didn't
find class "android.support.multidex.MultiDexApplication" on path:
DexPathList[[zip file "/system/framework/android.test.runner.jar", zip file
"/data/app/org.chromium.chrome.tests-1.apk"],nativeLibraryDirectories=[/data/app-lib/org.chromium.chrome.tests-1,
/vendor/lib, /system/lib]]
E/AndroidRuntime( 6139): 	at
dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)
E/AndroidRuntime( 6139): 	at
java.lang.ClassLoader.loadClass(ClassLoader.java:497)
E/AndroidRuntime( 6139): 	at
java.lang.ClassLoader.loadClass(ClassLoader.java:457)
E/AndroidRuntime( 6139): 	at
android.app.Instrumentation.newApplication(Instrumentation.java:975)
E/AndroidRuntime( 6139): 	at
android.app.LoadedApk.makeApplication(LoadedApk.java:502)
E/AndroidRuntime( 6139): 	... 11 more


enable_multidex does other extra stuff and appears to be needed for the
MultiDexApplication to work correctly.  Besides, the test target depends on
//base:base_java which already depends on this.

 }
 
 if (enable_vr) {
   instrumentation_test_apk("chrome_public_test_vr_apk") {
     apk_name = "ChromePublicTestVr"
     apk_under_test = ":chrome_public_apk"
     android_manifest = chrome_public_test_vr_apk_manifest
     android_manifest_dep = ":chrome_public_test_vr_apk_manifest"
 
     deps = [
@@ skipping 34 matching lines @@
   apk_name = "ChromeSyncShellTest"
   apk_under_test = ":chrome_sync_shell_apk"
   android_manifest = chrome_sync_shell_test_apk_manifest
   android_manifest_dep = ":chrome_sync_shell_test_apk_manifest"
   deps = [
     ":chrome_sync_shell_test_apk_java",
     "//third_party/android_support_test_runner:runner_java",
   ]
   proguard_enabled = !is_java_debug
 }