Issue 2905353002: Add type inference logic for map literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2905353002: Add type inference logic for map literals (Closed)

Created:
3 years, 7 months ago by Paul Berry

Modified:
3 years, 7 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add type inference logic for map literals R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d859cc6e4e6c8117810aa1cc6a4850c673aae9ce

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+368 lines, -24 lines)			Patch
M	pkg/front_end/lib/src/fasta/kernel/body_builder.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart	View	1 chunk	+68 lines, -7 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/front_end/test/fasta/strong.status	View	4 chunks	+0 lines, -13 lines	0 comments	Download
A	pkg/front_end/testcases/inference/downward_inference_miscellaneous.dart.strong.expect	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	pkg/front_end/testcases/inference/downwards_inference_yield_yield_star.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/downwards_inference_yield_yield_star.dart.strong.expect	View	1 chunk	+81 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/infer_list_literal_nested_in_map_literal.dart.strong.expect	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	pkg/front_end/testcases/inference/infer_typed_map_literal.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/infer_typed_map_literal.dart.strong.expect	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	pkg/front_end/testcases/inference/inferred_nonstatic_field_depends_on_static_field_complex.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/inferred_nonstatic_field_depends_on_static_field_complex.dart.strong.expect	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	pkg/front_end/testcases/inference/inferred_type_is_typedef.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/inferred_type_is_typedef.dart.strong.expect	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/front_end/testcases/inference/inferred_type_via_closure_multiple_levels_of_nesting.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/inferred_type_via_closure_multiple_levels_of_nesting.dart.strong.expect	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	pkg/front_end/testcases/inference/map_literals.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/map_literals.dart.strong.expect	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	pkg/front_end/testcases/inference/map_literals_can_infer_null.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/map_literals_can_infer_null.dart.strong.expect	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/front_end/testcases/inference/map_literals_top_level.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/map_literals_top_level.dart.strong.expect	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_map_dynamic.dart.strong.expect	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_map_typed.dart.strong.expect	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_map_untyped.dart.strong.expect	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

3 years, 7 months ago (2017-05-26 20:09:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d859cc6e4e6c8117810aa1cc6a4850c673aae9ce (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages