Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: components/safe_browsing/password_protection/password_protection_request.cc

Issue 2905343002: Show interstitial on a password on focus ping with PHISHING verdict. (Closed)
Patch Set: nit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_request.cc
diff --git a/components/safe_browsing/password_protection/password_protection_request.cc b/components/safe_browsing/password_protection/password_protection_request.cc
index 182070830a26ecde68b176edd60139bbb7e28ecc..0f74a1eebb88878ad158cdf0eb0d0ca9049bd7da 100644
--- a/components/safe_browsing/password_protection/password_protection_request.cc
+++ b/components/safe_browsing/password_protection/password_protection_request.cc
@@ -247,7 +247,7 @@ void PasswordProtectionRequest::Finish(
outcome, PasswordProtectionService::MAX_OUTCOME);
}
- if (response) {
+ if (outcome == PasswordProtectionService::SUCCEEDED && response) {
switch (request_type_) {
case LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE:
UMA_HISTOGRAM_ENUMERATION(
@@ -267,7 +267,9 @@ void PasswordProtectionRequest::Finish(
}
DCHECK(password_protection_service_);
- password_protection_service_->RequestFinished(this, std::move(response));
+ password_protection_service_->RequestFinished(
+ this, outcome == PasswordProtectionService::RESPONSE_ALREADY_CACHED,
+ std::move(response));
}
void PasswordProtectionRequest::Cancel(bool timed_out) {

Powered by Google App Engine
This is Rietveld 408576698