Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: components/safe_browsing/browser/threat_details.cc

Issue 2905343002: Show interstitial on a password on focus ping with PHISHING verdict. (Closed)
Patch Set: nit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing/base_ping_manager.cc ('k') | components/safe_browsing/csd.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing/browser/threat_details.cc
diff --git a/components/safe_browsing/browser/threat_details.cc b/components/safe_browsing/browser/threat_details.cc
index 0e6cfb8cf117a5f9ca81ce61eb8649cb78fedb1f..4a75c4ca9f5d7ac6d4316503937313de78206037 100644
--- a/components/safe_browsing/browser/threat_details.cc
+++ b/components/safe_browsing/browser/threat_details.cc
@@ -76,6 +76,8 @@ ClientSafeBrowsingReportRequest::ReportType GetReportTypeFromSBThreatType(
return ClientSafeBrowsingReportRequest::CLIENT_SIDE_PHISHING_URL;
case SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL:
return ClientSafeBrowsingReportRequest::CLIENT_SIDE_MALWARE_URL;
+ case SB_THREAT_TYPE_PASSWORD_PROTECTION_PHISHING_URL:
+ return ClientSafeBrowsingReportRequest::PASSWORD_PROTECTION_PHISHING_URL;
default: // Gated by SafeBrowsingBlockingPage::ShouldReportThreatDetails.
NOTREACHED() << "We should not send report for threat type "
<< threat_type;
@@ -359,6 +361,9 @@ void ThreatDetails::StartCollection() {
report_->set_type(GetReportTypeFromSBThreatType(resource_.threat_type));
}
+ if (resource_.threat_type == SB_THREAT_TYPE_PASSWORD_PROTECTION_PHISHING_URL)
+ report_->set_token(resource_.token);
+
GURL referrer_url;
NavigationEntry* nav_entry = resource_.GetNavigationEntryForResource();
if (nav_entry) {
« no previous file with comments | « components/safe_browsing/base_ping_manager.cc ('k') | components/safe_browsing/csd.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698