chrome/browser/safe_browsing/safe_browsing_blocking_page.cc - Issue 2905343002: Show interstitial on a password on focus ping with PHISHING verdict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 2905343002: Show interstitial on a password on focus ping with PHISHING verdict. (Closed)

Patch Set: address nparker's comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

index b0ccf2600d5eb9979de6e968b1d2a460a8f03182..0e6f81bf348a9ccbf441b1d09d83f3e3b9570079 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

@@ -143,7 +143,8 @@ bool SafeBrowsingBlockingPage::ShouldReportThreatDetails(

threat_type == SB_THREAT_TYPE_URL_MALWARE ||

threat_type == SB_THREAT_TYPE_URL_UNWANTED ||

threat_type == SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL ||

- threat_type == SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL;

+ threat_type == SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL ||

+ threat_type == SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL;

}

SafeBrowsingBlockingPage::~SafeBrowsingBlockingPage() {