Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: components/safe_browsing/base_blocking_page.cc

Issue 2905343002: Show interstitial on a password on focus ping with PHISHING verdict. (Closed)
Patch Set: nit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/base_blocking_page.cc
diff --git a/components/safe_browsing/base_blocking_page.cc b/components/safe_browsing/base_blocking_page.cc
index eaddeb8d36124a4208e87384fa42995d82cc8a10..7be5986905d8d77b8c793fa0aa1b16d2e05538c2 100644
--- a/components/safe_browsing/base_blocking_page.cc
+++ b/components/safe_browsing/base_blocking_page.cc
@@ -266,6 +266,8 @@ std::string BaseBlockingPage::GetExtraMetricsSuffix(
return "from_device_v4";
case safe_browsing::ThreatSource::CLIENT_SIDE_DETECTION:
return "from_client_side_detection";
+ case safe_browsing::ThreatSource::PASSWORD_PROTECTION_SERVICE:
+ return "from_password_protection_service";
case safe_browsing::ThreatSource::UNKNOWN:
break;
}
@@ -289,7 +291,8 @@ BaseBlockingPage::GetInterstitialReason(
harmful = true;
} else {
DCHECK(threat_type == SB_THREAT_TYPE_URL_PHISHING ||
- threat_type == SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL);
+ threat_type == SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL ||
+ threat_type == SB_THREAT_TYPE_PASSWORD_PROTECTION_PHISHING_URL);
}
}

Powered by Google App Engine
This is Rietveld 408576698