Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 2905283003: Remove a bunch of dead code around WindowFeatures (Closed)
Patch Set: Use WebWindowFeatures everywhere Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 16 matching lines...) Expand all
27 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 27 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
28 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 28 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
29 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 29 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
30 */ 30 */
31 31
32 #ifndef ChromeClientImpl_h 32 #ifndef ChromeClientImpl_h
33 #define ChromeClientImpl_h 33 #define ChromeClientImpl_h
34 34
35 #include <memory> 35 #include <memory>
36 #include "core/page/ChromeClient.h" 36 #include "core/page/ChromeClient.h"
37 #include "core/page/WindowFeatures.h"
38 #include "platform/graphics/TouchAction.h" 37 #include "platform/graphics/TouchAction.h"
39 #include "public/web/WebNavigationPolicy.h" 38 #include "public/web/WebNavigationPolicy.h"
39 #include "public/web/WebWindowFeatures.h"
40 #include "web/WebExport.h" 40 #include "web/WebExport.h"
41 41
42 namespace blink { 42 namespace blink {
43 43
44 class PagePopup; 44 class PagePopup;
45 class PagePopupClient; 45 class PagePopupClient;
46 class WebViewBase; 46 class WebViewBase;
47 struct WebCursorInfo; 47 struct WebCursorInfo;
48 48
49 // Handles window-level notifications from core on behalf of a WebView. 49 // Handles window-level notifications from core on behalf of a WebView.
(...skipping 16 matching lines...) Expand all
66 void BeginLifecycleUpdates() override; 66 void BeginLifecycleUpdates() override;
67 bool HadFormInteraction() const override; 67 bool HadFormInteraction() const override;
68 void StartDragging(LocalFrame*, 68 void StartDragging(LocalFrame*,
69 const WebDragData&, 69 const WebDragData&,
70 WebDragOperationsMask, 70 WebDragOperationsMask,
71 const WebImage& drag_image, 71 const WebImage& drag_image,
72 const WebPoint& drag_image_offset) override; 72 const WebPoint& drag_image_offset) override;
73 bool AcceptsLoadDrops() const override; 73 bool AcceptsLoadDrops() const override;
74 Page* CreateWindow(LocalFrame*, 74 Page* CreateWindow(LocalFrame*,
75 const FrameLoadRequest&, 75 const FrameLoadRequest&,
76 const WindowFeatures&, 76 const WebWindowFeatures&,
77 NavigationPolicy) override; 77 NavigationPolicy) override;
78 void Show(NavigationPolicy) override; 78 void Show(NavigationPolicy) override;
79 void DidOverscroll(const FloatSize& overscroll_delta, 79 void DidOverscroll(const FloatSize& overscroll_delta,
80 const FloatSize& accumulated_overscroll, 80 const FloatSize& accumulated_overscroll,
81 const FloatPoint& position_in_viewport, 81 const FloatPoint& position_in_viewport,
82 const FloatSize& velocity_in_viewport) override; 82 const FloatSize& velocity_in_viewport) override;
83 void SetToolbarsVisible(bool) override;
84 bool ToolbarsVisible() override;
85 void SetStatusbarVisible(bool) override;
86 bool StatusbarVisible() override;
87 void SetScrollbarsVisible(bool) override;
88 bool ScrollbarsVisible() override;
89 void SetMenubarVisible(bool) override;
90 bool MenubarVisible() override;
91 void SetResizable(bool) override;
92 bool ShouldReportDetailedMessageForSource(LocalFrame&, 83 bool ShouldReportDetailedMessageForSource(LocalFrame&,
93 const String&) override; 84 const String&) override;
94 void AddMessageToConsole(LocalFrame*, 85 void AddMessageToConsole(LocalFrame*,
95 MessageSource, 86 MessageSource,
96 MessageLevel, 87 MessageLevel,
97 const String& message, 88 const String& message,
98 unsigned line_number, 89 unsigned line_number,
99 const String& source_id, 90 const String& source_id,
100 const String& stack_trace) override; 91 const String& stack_trace) override;
101 bool CanOpenBeforeUnloadConfirmPanel() override; 92 bool CanOpenBeforeUnloadConfirmPanel() override;
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 WebEventListenerClass, 138 WebEventListenerClass,
148 WebEventListenerProperties) override; 139 WebEventListenerProperties) override;
149 WebEventListenerProperties EventListenerProperties( 140 WebEventListenerProperties EventListenerProperties(
150 LocalFrame*, 141 LocalFrame*,
151 WebEventListenerClass) const override; 142 WebEventListenerClass) const override;
152 void UpdateEventRectsForSubframeIfNecessary(LocalFrame*); 143 void UpdateEventRectsForSubframeIfNecessary(LocalFrame*);
153 // Informs client about the existence of handlers for scroll events so 144 // Informs client about the existence of handlers for scroll events so
154 // appropriate scroll optimizations can be chosen. 145 // appropriate scroll optimizations can be chosen.
155 void SetHasScrollEventHandlers(LocalFrame*, bool has_event_handlers) override; 146 void SetHasScrollEventHandlers(LocalFrame*, bool has_event_handlers) override;
156 void SetTouchAction(LocalFrame*, TouchAction) override; 147 void SetTouchAction(LocalFrame*, TouchAction) override;
148 const WebInputEvent* GetCurrentInputEvent() const override;
157 149
158 void AttachRootGraphicsLayer(GraphicsLayer*, LocalFrame* local_root) override; 150 void AttachRootGraphicsLayer(GraphicsLayer*, LocalFrame* local_root) override;
159 151
160 void AttachRootLayer(WebLayer*, LocalFrame* local_root) override; 152 void AttachRootLayer(WebLayer*, LocalFrame* local_root) override;
161 153
162 void AttachCompositorAnimationTimeline(CompositorAnimationTimeline*, 154 void AttachCompositorAnimationTimeline(CompositorAnimationTimeline*,
163 LocalFrame*) override; 155 LocalFrame*) override;
164 void DetachCompositorAnimationTimeline(CompositorAnimationTimeline*, 156 void DetachCompositorAnimationTimeline(CompositorAnimationTimeline*,
165 LocalFrame*) override; 157 LocalFrame*) override;
166 158
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 WebRemoteFrameBase* GetWebRemoteFrameBase(RemoteFrame&) override; 233 WebRemoteFrameBase* GetWebRemoteFrameBase(RemoteFrame&) override;
242 234
243 private: 235 private:
244 explicit ChromeClientImpl(WebViewBase*); 236 explicit ChromeClientImpl(WebViewBase*);
245 237
246 bool IsChromeClientImpl() const override { return true; } 238 bool IsChromeClientImpl() const override { return true; }
247 239
248 void SetCursor(const WebCursorInfo&, LocalFrame*); 240 void SetCursor(const WebCursorInfo&, LocalFrame*);
249 241
250 WebViewBase* web_view_; // Weak pointer. 242 WebViewBase* web_view_; // Weak pointer.
251 WindowFeatures window_features_;
252 Vector<PopupOpeningObserver*> popup_opening_observers_; 243 Vector<PopupOpeningObserver*> popup_opening_observers_;
253 Cursor last_set_mouse_cursor_for_testing_; 244 Cursor last_set_mouse_cursor_for_testing_;
254 bool cursor_overridden_; 245 bool cursor_overridden_;
255 bool did_request_non_empty_tool_tip_; 246 bool did_request_non_empty_tool_tip_;
256 }; 247 };
257 248
258 DEFINE_TYPE_CASTS(ChromeClientImpl, 249 DEFINE_TYPE_CASTS(ChromeClientImpl,
259 ChromeClient, 250 ChromeClient,
260 client, 251 client,
261 client->IsChromeClientImpl(), 252 client->IsChromeClientImpl(),
262 client.IsChromeClientImpl()); 253 client.IsChromeClientImpl());
263 254
264 } // namespace blink 255 } // namespace blink
265 256
266 #endif 257 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698