Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Side by Side Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2905283003: Remove a bunch of dead code around WindowFeatures (Closed)
Patch Set: Use WebWindowFeatures everywhere Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 4 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
5 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 5 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
6 * (http://www.torchmobile.com/) 6 * (http://www.torchmobile.com/)
7 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 7 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
8 * Copyright (C) Research In Motion Limited 2009. All rights reserved. 8 * Copyright (C) Research In Motion Limited 2009. All rights reserved.
9 * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com> 9 * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com>
10 * Copyright (C) 2011 Google Inc. All rights reserved. 10 * Copyright (C) 2011 Google Inc. All rights reserved.
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 #include "core/loader/LinkLoader.h" 68 #include "core/loader/LinkLoader.h"
69 #include "core/loader/MixedContentChecker.h" 69 #include "core/loader/MixedContentChecker.h"
70 #include "core/loader/NavigationScheduler.h" 70 #include "core/loader/NavigationScheduler.h"
71 #include "core/loader/NetworkHintsInterface.h" 71 #include "core/loader/NetworkHintsInterface.h"
72 #include "core/loader/ProgressTracker.h" 72 #include "core/loader/ProgressTracker.h"
73 #include "core/loader/appcache/ApplicationCacheHost.h" 73 #include "core/loader/appcache/ApplicationCacheHost.h"
74 #include "core/page/ChromeClient.h" 74 #include "core/page/ChromeClient.h"
75 #include "core/page/CreateWindow.h" 75 #include "core/page/CreateWindow.h"
76 #include "core/page/FrameTree.h" 76 #include "core/page/FrameTree.h"
77 #include "core/page/Page.h" 77 #include "core/page/Page.h"
78 #include "core/page/WindowFeatures.h"
79 #include "core/page/scrolling/ScrollingCoordinator.h" 78 #include "core/page/scrolling/ScrollingCoordinator.h"
80 #include "core/probe/CoreProbes.h" 79 #include "core/probe/CoreProbes.h"
81 #include "core/svg/graphics/SVGImage.h" 80 #include "core/svg/graphics/SVGImage.h"
82 #include "core/xml/parser/XMLDocumentParser.h" 81 #include "core/xml/parser/XMLDocumentParser.h"
83 #include "platform/InstanceCounters.h" 82 #include "platform/InstanceCounters.h"
84 #include "platform/PluginScriptForbiddenScope.h" 83 #include "platform/PluginScriptForbiddenScope.h"
85 #include "platform/ScriptForbiddenScope.h" 84 #include "platform/ScriptForbiddenScope.h"
86 #include "platform/bindings/DOMWrapperWorld.h" 85 #include "platform/bindings/DOMWrapperWorld.h"
87 #include "platform/instrumentation/tracing/TraceEvent.h" 86 #include "platform/instrumentation/tracing/TraceEvent.h"
88 #include "platform/loader/fetch/ResourceFetcher.h" 87 #include "platform/loader/fetch/ResourceFetcher.h"
(...skipping 1589 matching lines...) Expand 10 before | Expand all | Expand 10 after
1678 // TODO(japhet): This is needed because the browser process DCHECKs if the 1677 // TODO(japhet): This is needed because the browser process DCHECKs if the
1679 // first entry we commit in a new frame has replacement set. It's unclear 1678 // first entry we commit in a new frame has replacement set. It's unclear
1680 // whether the DCHECK is right, investigate removing this special case. 1679 // whether the DCHECK is right, investigate removing this special case.
1681 bool replace_current_item = load_type == kFrameLoadTypeReplaceCurrentItem && 1680 bool replace_current_item = load_type == kFrameLoadTypeReplaceCurrentItem &&
1682 (!Opener() || !request.Url().IsEmpty()); 1681 (!Opener() || !request.Url().IsEmpty());
1683 loader->SetReplacesCurrentHistoryItem(replace_current_item); 1682 loader->SetReplacesCurrentHistoryItem(replace_current_item);
1684 return loader; 1683 return loader;
1685 } 1684 }
1686 1685
1687 } // namespace blink 1686 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698