Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 2905243003: Cleanup BookmarkBubbleView, remove LocationBarBubbleDelegateView::GetDialogButtons() (Closed)
Patch Set: neater Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/translate/translate_bubble_view.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc
index 3d83388b61d95c2fcf091dc3efe66fe4fd6e4750..99a6976b8660ee54a9a0cd2523b9b2aa1457cc5f 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc
@@ -155,6 +155,11 @@ void TranslateBubbleView::CloseBubble() {
LocationBarBubbleDelegateView::CloseBubble();
}
+int TranslateBubbleView::GetDialogButtons() const {
+ // TODO(estade): this should be using GetDialogButtons().
+ return ui::DIALOG_BUTTON_NONE;
+}
+
void TranslateBubbleView::Init() {
SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0));
@@ -895,7 +900,6 @@ views::View* TranslateBubbleView::CreateViewAdvanced() {
advanced_cancel_button_ = views::MdTextButton::CreateSecondaryUiButton(
this, l10n_util::GetStringUTF16(IDS_CANCEL));
advanced_cancel_button_->set_id(BUTTON_ID_CANCEL);
- // TODO(estade): this should be using GetDialogButtons().
layout->AddView(advanced_done_button_);
layout->AddView(advanced_cancel_button_);

Powered by Google App Engine
This is Rietveld 408576698