Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

Issue 2905233002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
index a3466a06728f0d90d5f9c40b17fdf6c67cb4c2d1..98038c20872b523e33847478aa8e8652a4b2b636 100644
--- a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
@@ -95,6 +95,11 @@ DEFINE_TRACE(HTMLVideoElement) {
HTMLMediaElement::Trace(visitor);
}
+bool HTMLVideoElement::HasPendingActivity() const {
+ return HTMLMediaElement::HasPendingActivity() ||
+ (image_loader_ && image_loader_->HasPendingActivity());
+}
+
Node::InsertionNotificationRequest HTMLVideoElement::InsertedInto(
ContainerNode* insertion_point) {
if (insertion_point->isConnected() && custom_controls_fullscreen_detector_)
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLVideoElement.h ('k') | third_party/WebKit/Source/core/html/HTMLVideoElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698